Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing in a non-escaped table to the lsn lookup function #85

Merged

Conversation

s7clarke10
Copy link
Collaborator

The SQL Server function sys.fn_cdc_get_min_lsn should receive an unescaped table name (because this is a function an the input should be a parameter in single quotes - not an escaped table in double-quotes).

The resolution to this issue is to provide an unescaped table to the get_lsn_available_range function.

This will resolve #83 .

@s7clarke10 s7clarke10 requested a review from mjsqu October 8, 2024 02:33
@s7clarke10 s7clarke10 added the bug Something isn't working label Oct 8, 2024
@s7clarke10 s7clarke10 changed the title Passing in a non-escaped table to the lsn lookup function Draft: Passing in a non-escaped table to the lsn lookup function Oct 8, 2024
@s7clarke10
Copy link
Collaborator Author

s7clarke10 commented Oct 8, 2024

Note: Checkng this in Meltano to ensure the ingestion works as expected.

I have verified that this has resolved the issue 😊

@s7clarke10 s7clarke10 marked this pull request as draft October 8, 2024 04:56
@s7clarke10 s7clarke10 changed the title Draft: Passing in a non-escaped table to the lsn lookup function Passing in a non-escaped table to the lsn lookup function Oct 8, 2024
@s7clarke10 s7clarke10 self-assigned this Oct 8, 2024
@mjsqu mjsqu marked this pull request as ready for review October 9, 2024 00:28
Copy link
Collaborator

@mjsqu mjsqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! :)

@mjsqu mjsqu merged commit b82bafb into wintersrd:master Oct 9, 2024
1 check passed
@s7clarke10 s7clarke10 deleted the bug/fix_escaping_for_table_lsn_function branch October 17, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly escaped capture instance name
2 participants