Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing in a non-escaped table to the lsn lookup function #85

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Passing in a non-escaped table to the lsn lookup function #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6153cc9
Passing in a non-escaped table to the lsn lookup function
s7clarke10 Oct 8, 2024
48e7bbf
Bumping version numbers and adding log
s7clarke10 Oct 9, 2024
4c65399
Updating lock file and dependencies
s7clarke10 Oct 9, 2024
61907ec
Passing the correct formatted cdc table name
s7clarke10 Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 2.6.0
current_version = 2.6.1
parse = (?P<major>\d+)
\.(?P<minor>\d+)
\.(?P<patch>\d+)
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# tap-mssql 2.6.1 2024-10-09
* Resolving issue with call get the prior LSN number (passing in unescaped table).

# tap-mssql 2.6.0 2024-09-02
* Resolving issue LOG_BASED tables with special characters. Escaping the object
names with double quotes. Issue #74
Expand Down
156 changes: 82 additions & 74 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "tap-mssql"
version = "2.6.0"
version = "2.6.1"
description = "A pipelinewise compatible tap for connecting Microsoft SQL Server"
authors = ["Rob Winters <[email protected]>"]
license = "GNU Affero"
Expand Down
2 changes: 1 addition & 1 deletion tap_mssql/sync_strategies/log_based.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def sync_table(mssql_conn, config, catalog_entry, state, columns, stream_version
).format(escaped_schema_name, escape_table_name)
)

lsn_range = get_lsn_available_range(mssql_conn, escaped_cdc_table)
lsn_range = get_lsn_available_range(mssql_conn, cdc_table)

if lsn_range[0] is not None: # Test to see if there are any change records to process
lsn_from = str(lsn_range[0].hex())
Expand Down
Loading