Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 CPU id: fix for privilege instruction detection #8311

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

SparkiDev
Copy link
Contributor

@SparkiDev SparkiDev commented Dec 23, 2024

Description

AES/PMULL is in four bits 4-7.
When value is 0b0010, this indicates both AES and PMULL. Fix code to set both.

Testing

./configure '--disable-shared' 'LDFLAGS=--static' '--host=aarch64' 'CC=aarch64-linux-gnu-gcc' '--enable-armasm' '--enable-all' '-disable-crl-monitor' 'CFLAGS=-DWOLFSSL_AARCH64_PRIVILEGE_MODE'
./wolfcrypt/test/testwolfcrypt fails at AES-GCM.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Dec 23, 2024
@SparkiDev SparkiDev force-pushed the aarch64_cpuid_fix branch 2 times, most recently from 4f6c8a6 to ef4895f Compare December 23, 2024 01:15
AES/PMULL is in four bits 4-7.
When value is 0b0010, this indicates both AES and PMULL. Fix code to set
both.
@SparkiDev
Copy link
Contributor Author

retest this please

Windows test ACVP failed.
"Didn't fail the number of expected times."

Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douzzer douzzer merged commit a13d0fd into wolfSSL:master Dec 23, 2024
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants