Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle container offsets in distance & angle measurement #794

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

Kurtil
Copy link
Contributor

@Kurtil Kurtil commented Jan 5, 2022

If a container is given to the corresponding plugins, (other than document.body by default), and if the container is not at the top left of the body, the positions may be incorrect.

46801046d276a44f56f547c4ed3b0257

@magnayn
Copy link

magnayn commented Mar 24, 2022

This looks like it would fix my issue #820

@simplylogicninjas
Copy link

When will this PR merged? @xeolabs

@xeolabs xeolabs merged commit b083ab2 into xeokit:master Apr 12, 2022
@xeolabs
Copy link
Member

xeolabs commented Apr 12, 2022

Now merged: @xeokit/xeokit-sdk 2.2.5-beta-4

@Amoki Amoki deleted the patch-7 branch April 12, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants