Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle container offsets in distance & angle measurement #794

Merged
merged 2 commits into from
Apr 12, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/plugins/AngleMeasurementsPlugin/AngleMeasurement.js
Original file line number Diff line number Diff line change
@@ -197,8 +197,9 @@ class AngleMeasurement extends Component {

var canvas = scene.canvas.canvas;
var offsets = canvas.getBoundingClientRect();
var top = offsets.top;
var left = offsets.left;
const containerOffsets = this._container.getBoundingClientRect();
var top = offsets.top - containerOffsets.top;
var left = offsets.left - containerOffsets.left;
var aabb = scene.canvas.boundary;
var canvasWidth = aabb[2];
var canvasHeight = aabb[3];
@@ -510,4 +511,4 @@ class AngleMeasurement extends Component {
}
}

export {AngleMeasurement};
export {AngleMeasurement};
5 changes: 3 additions & 2 deletions src/plugins/DistanceMeasurementsPlugin/DistanceMeasurement.js
Original file line number Diff line number Diff line change
@@ -260,8 +260,9 @@ class DistanceMeasurement extends Component {

var canvas = scene.canvas.canvas;
var offsets = canvas.getBoundingClientRect();
var top = offsets.top;
var left = offsets.left;
const containerOffsets = this._container.getBoundingClientRect();
var top = offsets.top - containerOffsets.top;
var left = offsets.left - containerOffsets.left;
var aabb = scene.canvas.boundary;
var canvasWidth = aabb[2];
var canvasHeight = aabb[3];