search-core: add cloudChoice enum and config support #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the new cloudChoice config property, to allow choosing either all consumer serving regions, or just the ones backed by GCP. By default the Multi option will be used, so default behavior is unchanged. J=WAT-4374 TEST=auto Added new test class
Fondryext
commented
Sep 10, 2024
Pull Request Test Coverage Report for Build 10811739400Details
💛 - Coveralls |
sahilvaidya
approved these changes
Sep 10, 2024
sahilvaidya
approved these changes
Sep 11, 2024
Merged
Fondryext
added a commit
that referenced
this pull request
Sep 11, 2024
**Changes:** - Adds new cloudChoice config property #277
vijay267
reviewed
Sep 11, 2024
dxodja
reviewed
Nov 3, 2024
| @@ -0,0 +1,21 @@ | |||
| <!-- Do not edit this file. It is automatically generated by API Documenter. --> | |||
|
|
|||
| [Home](./index.md) > [@yext/search-core](./search-core.md) > [CloudChoice](./search-core.cloudchoice.md) | |||
There was a problem hiding this comment.
Suggested change
| [Home](./index.md) > [@yext/search-core](./search-core.md) > [CloudChoice](./search-core.cloudchoice.md) | |
| [Home](./index.md) > [@yext/search-core](./search-core.md) > [CloudChoice](./search-core.cloudchoice.md) | |
| **```suggestion | |
| [Home](./index.md) > [@yext/search-core](./search-core.md) > [CloudChoice](./search-core.cloudchoice.md) | |
| ```suggestion | |
| [Home](./index.md) > [@yext/search-core](./search-core.md) > [CloudChoice](./search-core.cloudchoice.md) |
**
Fondryext
added a commit
that referenced
this pull request
Dec 9, 2024
This PR adds the new cloudChoice config property, to allow choosing either all consumer serving regions, or just the ones backed by GCP. By default the Multi option will be used, so default behavior is unchanged. J=WAT-4374 TEST=auto Added new test class --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new cloudChoice config property, to allow choosing either all consumer serving regions, or just the ones backed by GCP. By default the Multi option will be used, so default behavior is unchanged.
J=WAT-4374
TEST=auto
Added new test class