Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.5.4 #278

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Version 2.5.4 #278

merged 1 commit into from
Sep 11, 2024

Conversation

Fondryext
Copy link
Contributor

Changes:

@Fondryext @github-actions
search-core: add cloudChoice enum and config support (#277)
3951cbd 
This PR adds the new cloudChoice config property, to allow
choosing either all consumer serving regions, or just the ones
backed by GCP. By default the Multi option will be used, so
default behavior is unchanged.

J=WAT-4374
TEST=auto

Added new test class

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@Fondryext Fondryext requested a review from a team as a code owner September 11, 2024 14:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10813395710

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.1%
Totals Coverage Status
Change from base Build 10793871654: 0.2%
Covered Lines: 213
Relevant Lines: 233
💛 - Coveralls

@Fondryext Fondryext merged commit 2b6bfc4 into master Sep 11, 2024
16 checks passed
@Fondryext Fondryext mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahilvaidya sahilvaidya sahilvaidya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fondryext @coveralls @sahilvaidya