Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Mido functions, fields, and animations #2289

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Feacur
Copy link
Contributor

@Feacur Feacur commented Nov 7, 2024

additionally,

  • document func_80034DD4 as Actor_UpdateAlphaByDistance @ z64actor.h
    • commit b86fa44
    • used for two actors only, Mido and Saria; the latter is intact otherwise
    • somewhat required to understand name change func_80AAB5A4 -> EnMd_UpdateAlphaByDistance
  • (re)documented Mido's animations, so that his animation state machine is clearer

P.S.:
found out that blinking sequences does't follow the eyes textures order, and it's obvious in hindsight. for example, z_en_go2.c goes "closed2, open, half, closed", and the blinking function resets the index to 1, i.e. "open"

also, it seems that actionFunc is rather stateFunc, because de facto it is being used as state machine; but it's no matter

new name: `EnMd_ReverseAnimation`
the list:

* `func_80AAAC78` -> `EnMd_TrackMessageState`
* `func_80AAAA24` -> `EnMd_UpdateAnimState_WithTalking`

* `func_80AAA92C` -> `EnMd_SetAnimState`
* `func_80AAA93C` -> `EnMd_UpdateAnimState`
* `func_80AAA274` -> `EnMd_UpdateAnimState1`
* `func_80AAA308` -> `EnMd_UpdateAnimState2`
* `func_80AAA39C` -> `EnMd_UpdateAnimState3`
* `func_80AAA474` -> `EnMd_UpdateAnimState4`
* `func_80AAA508` -> `EnMd_UpdateAnimState5`
* `func_80AAA5A4` -> `EnMd_UpdateAnimState6`
* `func_80AAA638` -> `EnMd_UpdateAnimState7`
* `func_80AAA6D4` -> `EnMd_UpdateAnimState8`
* `func_80AAA768` -> `EnMd_UpdateAnimState9`
* `func_80AAA7FC` -> `EnMd_UpdateAnimState10`
* `func_80AAA890` -> `EnMd_UpdateAnimState11`
new name: `EnMd_UpdateTalking`
new name: `Actor_SmoothStep_Attention`
new name: `EnMd_SmoothStep_Attention`
the list:
* `func_80AAB874` -> `EnMd_Idle`
* `func_80AAB8F8` -> `EnMd_Watch`
* `func_80AAB948` -> `EnMd_BlockPath`
* `func_80AABC10` -> `EnMd_ListenToOcarina`
* `func_80AABD0C` -> `EnMd_Walk`
via blender and fast64
@Feacur Feacur changed the title Document Mido functions and fields Document Mido functions, fields, and animations Nov 8, 2024
to clarify for `EnMd_UpdateEyes`
Mido has two eyes and different textures for them
i was wrong: `_Draw` function might not follow the eyes texture order
it is its own thing, like `enum EnMdBlinking` or nothing at all, yeah
src/code/z_actor.c Show resolved Hide resolved
src/overlays/actors/ovl_En_Md/z_en_md.c Outdated Show resolved Hide resolved
src/overlays/actors/ovl_En_Md/z_en_md.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants