Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics / k1ch/ Admin API / DELETE:/personas/{persona_key}/roles/{role_key} #89

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Jan 23, 2024

Overview

OAS document:

image

Added tests:

image

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Closes #58

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Jan 23, 2024
@k1ch k1ch force-pushed the topics/k1ch/admin-delete-personas-roles branch from b1e0ee9 to 9db8eb7 Compare January 25, 2024 21:04
@k1ch k1ch marked this pull request as ready for review January 25, 2024 21:07
@k1ch k1ch requested a review from mikelax January 25, 2024 21:07
mikelax
mikelax previously approved these changes Jan 26, 2024
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @k1ch . A couple of minor items to think about.

  1. for the helper function deletePersonasRoles (and future functions) maybe consider adding jsdoc as it took me a minute to understand the function calls in those delete tests were using a local function that was then making the API call.

@k1ch k1ch merged commit 920b963 into main Jan 26, 2024
4 checks passed
@k1ch k1ch deleted the topics/k1ch/admin-delete-personas-roles branch January 26, 2024 19:03
@k1ch k1ch added the component: admin Administration related functionality label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Administration related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement APIs for Persona Roles management
2 participants