fix: use inert on host elements instead of aria-hidden when host element is hidden #11056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
added
no changelog entry
driskull
changed the title
|
I wasn't sure about combobox-item or icon so I left them alone. |
jcfranco
approved these changes
Dec 16, 2024
driskull
added
pr ready for visual snapshots
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
…ent is hidden (#11056) **Related Issue:** #10731 ## Summary This will address the following Chrome console error caused by using the `ariaHidden` prop (after #10310): > Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden. Element with focus: span Ancestor with aria-hidden: <calcite-popover reference-element="reference-element" placement="auto" offset-distance="6" offset-skidding="0" text-close="Close" aria-hidden="true" aria-live="polite" id="calcite-popover-a872ffbb-85e1-5c2c-6f14-8108c4821728" role="dialog" overlay-positioning="absolute" scale="m" calcite-hydrated>…</calcite-popover>#shadow-root (open)<div style="width: 300px; padding:12px 16px;">…</div>slot</calcite-popover> BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
This will address the following Chrome console error caused by using the
ariaHiddenprop (after #10310):BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE