Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two step classifier #431
Add two step classifier #431
Changes from 23 commits
bf480ff
e6d3e3b
1c2065c
29168e4
124260f
6480c6a
e450f24
5850360
e8fcc3f
052c109
9df38a8
9e8c0c8
1605cfa
8551503
2d2be2a
7a1f4a7
ceabe7c
fdf62db
1c8157f
e6d6b95
65a11bb
ef6fc45
584bab7
c5e3eed
21da1be
7dd43a1
8c5547a
3d602af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check if this should rather be
if self._fitted:
? if not, add a comment which deconfuses me :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured, since we implement
Classifier
, which has the@property def fitted(self): ...
, one would useself._fitted
for setting, butself.fitted
for accessing, is that right? If so, I'll add a comment, or otherwise change it 😃There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it's the class accesing an instance variable, it's fine to use
self._fitted
(this is equivalent in terms of logic as here the property is a 1:1 wrapper aroundself._fitted
to make it public)more than "fine" actually: would prefer it for consistency :-)
@GeorgWa why do we have these properties anyway? they don't seem to be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anna-charlotte just FYI in case you also want to set your properties, you'd use the
@value.setter
decoratorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I figured we don't have the setter here, as we would want the
fitted
attribute to be read-only access for the user, otherwise would there be an advantage in this property being private, versus just haveing a.fitted
attribute?