One more channel added to Modbus slave table of Symmetric ESS #2257
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # io.openems.edge.ess.api/src/io/openems/edge/ess/api/SymmetricEss.java
tsicking
changed the title
|
I've updated this PR. |
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2257 +/- ##
=============================================
- Coverage 57.03% 57.02% -0.01%
+ Complexity 9810 9804 -6
=============================================
Files 2279 2279
Lines 97390 97390
Branches 7055 7055
=============================================
- Hits 55538 55527 -11
- Misses 39809 39821 +12
+ Partials 2043 2042 -1 |
clehne
approved these changes
Jan 24, 2025
|
@sfeilmeier Same here (see my comment on #2265). This PR is also old and it simply may have got lost in the crowd of PRs last year? Without this the Edge2EdgeEss will not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channels MAX_APPARENT_POWER and CAPACITY were added to the Modbus slave table of SymmetricEss.
Reason: MAX_APPARENT_POWER is needed for controlling an Edge2EdgeEss from remote (otherwise there may is an exception from the power component), and CAPACITY is needed for the controller "Grid optimized charge".