feat: various enhancements #508
Conversation
maciejmajek
force-pushed
the
refactor/demos
branch
from
5d8ee9c to
7e0cb26
Compare
docs/developer_guide/tools.md
Outdated
| ] | ||
| ``` | ||
|
|
||
| ### Using Tools in RAI Agent (Distributed Setup) |
There was a problem hiding this comment.
I would elaborate more on what distributed setup means
|
@coderabbitai full review |
This comment was marked as outdated.
This comment was marked as outdated.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
docs/demos/rosbot_xl.md
Outdated
There was a problem hiding this comment.
I would add some hints about the models. I think to make this demo to work, the requirement is that complex_model has to be set to VLM, that supports tool calling.
There was a problem hiding this comment.
| st.set_page_config( | ||
| page_title="RAI ROSBotXL Demo", | ||
| page_icon=":robot:", | ||
| ) | ||
|
|
||
|
|
||
| @st.cache_resource | ||
| def initialize_agent(): |
There was a problem hiding this comment.
How about using ROS2Context?
There was a problem hiding this comment.
Can't be done in this context as ROS2Context would also shutdown the rclpy on the return of initialize_agent
chore: import updates Co-authored-by: Bartłomiej Boczek <[email protected]>
maciejmajek
force-pushed
the
refactor/demos
branch
from
358a620 to
3cd8a01
Compare
There was a problem hiding this comment.
@maciejmajek
Tested again with prompts from the docs and they worked fine.
One thing that I've noticed is that recursion_limit should be increased, because it's too low. After it's fixed I'm fine with merging this PR.
langgraph.errors.GraphRecursionError: Recursion limit of 25 reached without hitting a stop condition. You can increase the limit by setting the `recursion_limit` config key. For troubleshooting, visit:
|
@boczekbartek thank you for the review. Here is a RFC regarding imports |
Purpose
This PR enhances the RAI framework with improved tool abstractions and action handling, legacy tool removal, while also modernizing the ROSBotXL demo.
Proposed Changes
Major Changes
Demo Simplification
Code Refactoring
GetROS2ImageConfiguredTool,GetROS2TransformConfiguredTool)Tool Improvements
CancelROS2ActionToolDocumentation Updates
Testing
Summary by CodeRabbit
Documentation
New Features
Refactoring & Removals
Tests