[tmpnet] Switch back to using maps for subnet config #3877
Merged
+15
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using subnet.Config to define subnet configuration initially seemed like a good idea - typing for the win - but went down in flames due to a combination the semantics of JSON marshaling and how subnet config defaults are set by the node. So, back to maps we go.
maru-ava
force-pushed
the
subnet-config-consensus-pointer
branch
from
7c40100 to
8eeca7f
Compare
Comment on lines
+36
to
+39
| Config: tmpnet.FlagsMap{ | ||
| // Reducing this from the 1s default speeds up tx acceptance | ||
| "proposerMinBlockDelay": 0, | ||
| }, |
There was a problem hiding this comment.
It's not a no-op - the default is 1s.
There was a problem hiding this comment.
Why include a non no-op config change in this PR? Just looking to understand here
There was a problem hiding this comment.
This addition ensures tmpnet usage of subnet configuration for non-primary subnets.
aaronbuchwald
approved these changes
Apr 11, 2025
StephenButtolph
approved these changes
Apr 14, 2025
This was referenced Apr 28, 2025
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Chain: tmpnet+kube
This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.
Why this should be merged
Using subnet.Config to define subnet configuration initially seemed like a good idea - typing for the win - but went down in flames due to a combination the semantics of JSON marshaling and how subnet config defaults are set by the node. So, back to maps we go.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A