-
Notifications
You must be signed in to change notification settings - Fork 745
[tmpnet] Move monitoring label handling to node #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR centralizes the handling of monitoring labels by moving the logic from the process runtime to the node, ensuring that both log and metric collection use the same label source.
- Removed inline monitoring label generation from process_runtime.go
- Introduced getMonitoringLabels() in node.go to encapsulate label determination
- Updated check_monitoring.go to use environment variables directly for GitHub labels selectors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/fixture/tmpnet/process_runtime.go | Removed explicit label mapping; now calls getMonitoringLabels() |
tests/fixture/tmpnet/node.go | Added getMonitoringLabels() and a global githubLabels variable for label names |
tests/fixture/tmpnet/check_monitoring.go | Revised fallback logic to retrieve GitHub labels directly from environment variables |
1 task
joshua-kim
approved these changes
Apr 18, 2025
2cf574c
to
a6d0977
Compare
5ccfadb
to
324a27a
Compare
JuanLeon2
approved these changes
Apr 23, 2025
324a27a
to
4785d43
Compare
This was referenced Apr 28, 2025
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Chain: tmpnet+kube
This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.
Why this should be merged
Previously, determination of labels to apply to collected logs and metrics was the responsibility of the process runtime. Since these labels are common to both runtimes, it makes sense for the node to own it.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A
TODO