[tmpnet] Ensure tmpnet methods always have a logger

[maru-ava]

PR Chain: tmpnet+kube

This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.

• [tmpnet] s/Network.ChainConfigs/Network.PrimaryChainConfigs/ #3854
• [tmpnet] Provide genesis, subnet and chain config via content flags #3857
• [tmpnet] Ensure Node has a reference to Network #3870
• [tmpnet] Switch back to using maps for subnet config #3877
• [tmpnet] Refactor runtime configuration in preparation for kube #3867
• [tmpnet] Unify start network flag usage between e2e and tmpnetctl #3871
• [tmpnet] Avoid serializing the node data directory #3881
• [tmpnet] Rename NodeProcess to ProcessRuntime #3890
• [tmpnet] Switch FlagsMap from map[string]any to map[string]string #3884
• >>>>>> [tmpnet] Ensure tmpnet methods always have a logger #3893 <<<<<<
• [tmpnet] Ensure all node runtime methods accept a context #3894
• [tmpnet] Move WaitForHealthy from a function to a tmpnet.Node method #3896
• [tmpnet] Delegate writing of the flag file to the runtime #3897
• [tmpnet] Move monitoring label handling to node #3898
• [tmpnet] Enable runtime-specific restart behavior #3882
• [tmpnet] Enable deployment to kube #3615
• [tmpnet] Enable monitoring of local kind cluster #3794

Why this should be merged

Previously individual tmpnet methods accepted a log argument where needed. Adding a log field to tmpnet.Network ensures that methods will always have access to a logger without the caller having to provide it past network initialization.

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

TODO

• Merge [tmpnet] Switch FlagsMap from map[string]any to map[string]string #3884

[Copilot]

Pull Request Overview

This PR embeds a logger in tmpnet.Network so that all tmpnet methods have consistent logging without requiring an explicit logger parameter in every call. Key changes include:

• Removing the logger parameter from method signatures in tmpnet and updating internal calls to use the network's logger field.
• Updating test files and helper functions to call the new method signatures and to pass a logger only during network initialization.
• Refactoring functions like ReadNetwork, StartNode, RestartNode, and StopNetwork to accommodate these changes.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/upgrade/upgrade_test.go	Updated StartNode call to remove logger argument.
tests/fixture/tmpnet/tmpnetctl/main.go	Refactored StopNetwork call to create and pass a logger.
tests/fixture/tmpnet/process_runtime.go	Refactored ProcessRuntime.Start to obtain the logger from the network field.
tests/fixture/tmpnet/node.go	Removed logger parameter from Node.Start and updated interface accordingly.
tests/fixture/tmpnet/network_test.go	Updated ReadNetwork call to pass a NoLog logger instance.
tests/fixture/tmpnet/network.go	Integrated a logger into the Network struct and refactored all logger usage.
tests/fixture/e2e/helpers.go	Updated StartNode invocation to align with the new signature.
tests/fixture/e2e/env.go	Revised environment initialization to supply a logger where needed.
tests/e2e/e2e_test.go	Adapted shared test environment initialization to use the new TestContext.

[maru-ava]

Rebased