FromWorld derive macro
#17352
Merged
FromWorld derive macro
#17352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
reviewed
Jan 13, 2025
MrGVSV
reviewed
Jan 13, 2025
ecoskey
force-pushed
the
derive_from_world
branch
from
69d8856 to
14b3d88
Compare
BenjaminBrienen
added
C-Feature
MrGVSV
approved these changes
Jan 15, 2025
Carter0
approved these changes
Jan 15, 2025
BenjaminBrienen
added
S-Ready-For-Final-Review
tychedelia
approved these changes
Jan 17, 2025
MrGVSV
reviewed
Jan 18, 2025
| let Data::Struct(DataStruct { fields, .. }) = &ast.data else { | ||
| return syn::Error::new( | ||
| Span::call_site(), | ||
| "#[derive(FromWorld)]` only supports structs", |
There was a problem hiding this comment.
Totally not required for this PR but one thing that just occurred to me is that we could add a #[from_world] helper that works sorta like Default's #[default], allowing for enums to utilize this derive macro too.
There was a problem hiding this comment.
ooh good idea. Might need to rework the internals a bit for that, so might be good for a followup :)
But I also might get bored and do it anyway lol
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
simple derive macro for `FromWorld`. Going to be needed for composable pipeline specializers but probably a nice thing to have regardless ## Testing simple manual testing, nothing seemed to blow up. I'm no proc macro pro though, so there's a chance I've mishandled spans somewhere or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple derive macro for
FromWorld. Going to be needed for composable pipeline specializers but probably a nice thing to have regardlessTesting
simple manual testing, nothing seemed to blow up. I'm no proc macro pro though, so there's a chance I've mishandled spans somewhere or something.