-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FromWorld
derive macro
#17352
Merged
Merged
FromWorld
derive macro
#17352
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cb73a5f
derive_from_world
ecoskey 74bf0c4
derive_from_world
ecoskey 2404e38
derive_from_world
ecoskey 8aa3e12
Merge branch 'main' into derive_from_world
ecoskey 7730d85
extract field init
ecoskey 771916b
add docs for derive
ecoskey 8a998f2
simplify initializers
ecoskey 1cd4df9
Merge branch 'main' into derive_from_world
ecoskey 14b3d88
remove extra imports
ecoskey da5abcf
Merge branch 'main' into derive_from_world
ecoskey 2780dc4
Merge branch 'main' into derive_from_world
ecoskey 8ac40cd
Merge branch 'main' into derive_from_world
ecoskey e589c14
Merge branch 'main' into derive_from_world
ecoskey dcf34f0
Merge branch 'main' into derive_from_world
ecoskey c742803
Merge branch 'main' into derive_from_world
ecoskey bfb26f9
Merge branch 'main' into derive_from_world
ecoskey 11e895e
Merge branch 'main' into derive_from_world
ecoskey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally not required for this PR but one thing that just occurred to me is that we could add a
#[from_world]
helper that works sorta likeDefault
's#[default]
, allowing for enums to utilize this derive macro too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh good idea. Might need to rework the internals a bit for that, so might be good for a followup :)
But I also might get bored and do it anyway lol