-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update build_op_context to build_asset_context where relevant #16673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Sep 20, 2023
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 21, 2023 17:13
5a064ff
to
63fde14
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 21, 2023 17:13
cbc9252
to
0512949
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 21, 2023 19:38
63fde14
to
2523258
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 21, 2023 19:38
0512949
to
ada6501
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 21, 2023 19:53
2523258
to
02e1483
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 21, 2023 19:54
ada6501
to
ea85284
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 21, 2023 20:15
02e1483
to
07101b5
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 21, 2023 20:15
ea85284
to
889a4af
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 21, 2023 21:02
07101b5
to
d14f690
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 21, 2023 21:02
adf9407
to
4871299
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 21, 2023 21:05
d14f690
to
ecb5178
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 21, 2023 21:05
4871299
to
362cb0f
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 22, 2023 13:08
ecb5178
to
9937b2f
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 22, 2023 13:08
909d8dc
to
6759fc4
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 22, 2023 14:27
9937b2f
to
a9785f3
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 22, 2023 14:27
6759fc4
to
7042434
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 22, 2023 15:16
a9785f3
to
583cb1e
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 22, 2023 15:16
7042434
to
b29961c
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 22, 2023 16:02
583cb1e
to
0885642
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 22, 2023 16:02
b29961c
to
5257cc4
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 22, 2023 17:47
0885642
to
84d7ea6
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 22, 2023 17:47
5257cc4
to
a53d70c
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 22, 2023 20:50
84d7ea6
to
a76c119
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 22, 2023 20:50
a53d70c
to
5ca0129
Compare
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-l28r0qu64-elementl.vercel.app Direct link to changed pages: |
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
September 26, 2023 14:06
a76c119
to
d2c1d93
Compare
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
September 26, 2023 14:06
5ca0129
to
3b8faaa
Compare
jamiedemaria
changed the base branch from
jamie/provide-asset-context
to
master
November 17, 2023 21:34
jamiedemaria
force-pushed
the
jamie/update-build-asset-context-usages
branch
from
November 17, 2023 21:34
3b8faaa
to
b6e2521
Compare
This was referenced Nov 17, 2023
Merged
alangenfeld
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates our tests and examples to use
build_asset_context
for assets that were previously using a context frombuild_op_context
How I Tested These Changes
BK