Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build_op_context to build_asset_context where relevant #16673

Merged
merged 8 commits into from
Nov 20, 2023

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Sep 20, 2023

Summary & Motivation

Updates our tests and examples to use build_asset_context for assets that were previously using a context from build_op_context

How I Tested These Changes

BK

@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 5a064ff to 63fde14 Compare September 21, 2023 17:13
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from cbc9252 to 0512949 Compare September 21, 2023 17:13
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 63fde14 to 2523258 Compare September 21, 2023 19:38
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 0512949 to ada6501 Compare September 21, 2023 19:38
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 2523258 to 02e1483 Compare September 21, 2023 19:53
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from ada6501 to ea85284 Compare September 21, 2023 19:54
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 02e1483 to 07101b5 Compare September 21, 2023 20:15
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from ea85284 to 889a4af Compare September 21, 2023 20:15
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 07101b5 to d14f690 Compare September 21, 2023 21:02
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from adf9407 to 4871299 Compare September 21, 2023 21:02
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from d14f690 to ecb5178 Compare September 21, 2023 21:05
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 4871299 to 362cb0f Compare September 21, 2023 21:05
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from ecb5178 to 9937b2f Compare September 22, 2023 13:08
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 909d8dc to 6759fc4 Compare September 22, 2023 13:08
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 9937b2f to a9785f3 Compare September 22, 2023 14:27
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 6759fc4 to 7042434 Compare September 22, 2023 14:27
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from a9785f3 to 583cb1e Compare September 22, 2023 15:16
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 7042434 to b29961c Compare September 22, 2023 15:16
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 583cb1e to 0885642 Compare September 22, 2023 16:02
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from b29961c to 5257cc4 Compare September 22, 2023 16:02
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 0885642 to 84d7ea6 Compare September 22, 2023 17:47
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 5257cc4 to a53d70c Compare September 22, 2023 17:47
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from 84d7ea6 to a76c119 Compare September 22, 2023 20:50
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from a53d70c to 5ca0129 Compare September 22, 2023 20:50
@jamiedemaria jamiedemaria force-pushed the jamie/provide-asset-context branch from a76c119 to d2c1d93 Compare September 26, 2023 14:06
@jamiedemaria jamiedemaria force-pushed the jamie/update-build-asset-context-usages branch from 5ca0129 to 3b8faaa Compare September 26, 2023 14:06
@jamiedemaria jamiedemaria marked this pull request as ready for review November 20, 2023 16:18
@jamiedemaria jamiedemaria merged commit 993237e into master Nov 20, 2023
2 checks passed
@jamiedemaria jamiedemaria deleted the jamie/update-build-asset-context-usages branch November 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants