-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prototype] AssetExecutionContext partition methods on sub context #19236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2024
Merged
38b66f9
to
50c80ab
Compare
53676ac
to
3db0d20
Compare
50c80ab
to
1fee854
Compare
3db0d20
to
9405338
Compare
This was referenced Jan 18, 2024
1fee854
to
558590d
Compare
9405338
to
4cde14d
Compare
558590d
to
bcc9cab
Compare
4cde14d
to
4963964
Compare
bcc9cab
to
af681dc
Compare
4963964
to
c583b85
Compare
af681dc
to
3016287
Compare
c583b85
to
e0845f3
Compare
3016287
to
04fd627
Compare
e0845f3
to
fa03263
Compare
This was referenced Jan 26, 2024
04fd627
to
0e1fc3e
Compare
fa03263
to
5621118
Compare
0e1fc3e
to
dc6edf0
Compare
5621118
to
b0b01ba
Compare
dc6edf0
to
ccc4260
Compare
b0b01ba
to
3b9df09
Compare
ccc4260
to
f416c05
Compare
3b9df09
to
7194e6f
Compare
f416c05
to
51d46aa
Compare
7194e6f
to
529b017
Compare
51d46aa
to
2670364
Compare
529b017
to
b526d68
Compare
2670364
to
2660075
Compare
b526d68
to
6676a12
Compare
2660075
to
a5828e1
Compare
6676a12
to
fbe85cf
Compare
a5828e1
to
f5be566
Compare
fbe85cf
to
7624561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR is a prototype for a potential API for partition methods on the
AssetExecutionContext
. This version moves all of the partition related properties and methods to aPartitionContext
object so that they are grouped and made a more distinct from other context methodsHooli PR - dagster-io/hooli-data-eng-pipelines#61
DOP PR - https://github.com/dagster-io/internal/pull/7931
Nice things about this design:
PartitionContext
.issues with this API design:
partition
. But the removal of some of thepartitions
may sacrifice clarityHow I Tested These Changes