Add AssetGraphView.create_latest_time_window_slice #20352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
schrockn
force-pushed
the
asset-graph-view-1
branch
from
f976741 to
7ffcdd1
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
2 times, most recently
from
1f5e51f to
90a0736
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
2 times, most recently
from
aa23d4e to
0c64516
Compare
This was referenced Mar 8, 2024
schrockn
force-pushed
the
asset-graph-view-1
branch
from
6210591 to
99cd2dc
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
from
0c64516 to
fb2c810
Compare
smackesey
reviewed
Mar 8, 2024
python_modules/dagster/dagster/_core/asset_graph_view/asset_graph_view.py
Outdated
Show resolved
Hide resolved
| def latest_time_window_slice(self) -> "AssetSlice": | ||
| """Returns the latest time window for the asset slice. | ||
|
|
||
| If the asset slice is time-window-partitiond (e.g. daily, hourly), |
schrockn
force-pushed
the
asset-graph-view-1
branch
2 times, most recently
from
b92518d to
6bb9be9
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
from
fb2c810 to
aa748ae
Compare
Closed
schrockn
force-pushed
the
asset-graph-view-2
branch
from
aa748ae to
5bfd3c4
Compare
This was referenced Mar 10, 2024
schrockn
force-pushed
the
asset-graph-view-1
branch
2 times, most recently
from
b2a2725 to
25abc9f
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
from
5bfd3c4 to
8e151ba
Compare
schrockn
force-pushed
the
asset-graph-view-1
branch
from
25abc9f to
1a3f697
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
from
8e151ba to
1d2e500
Compare
schrockn
force-pushed
the
asset-graph-view-2
branch
3 times, most recently
from
fdc715f to
1077b0d
Compare
schrockn
commented
Mar 12, 2024
Comment on lines
+161
to
+163
| def time_windows(self) -> Sequence[TimeWindow]: | ||
| """Get the time windows for the asset slice. Only supports explicitly time-windowed partitions for now.""" | ||
| # Only supports explicitly time-windows partitions for now |
There was a problem hiding this comment.
I'm going to change this to support all time windows later. In a bit of rebase hell right now.
schrockn
changed the title
schrockn
commented
Mar 12, 2024
schrockn
force-pushed
the
asset-graph-view-2
branch
from
9e70a03 to
b0423d4
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b0423d4. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-aqw6hzff1-elementl.vercel.app Direct link to changed pages: |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit b0423d4. |
smackesey
approved these changes
Mar 13, 2024
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Add `create_latest_time_window_slice` property to `AssetGraphView`. It gets an `AssetSlice` of the latest time window relative to the effective date of the `AssetGraphView`. ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add
create_latest_time_window_sliceproperty toAssetGraphView. It gets anAssetSliceof the latest time window relative to the effective date of theAssetGraphView.How I Tested These Changes
BK