Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsynced status to AssetSlice #20358

Closed
wants to merge 1 commit into from

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Mar 8, 2024

Summary & Motivation

Adding the ability to interrogate the AssetSlice for its sync status.

We are going to move to the term "unsynced" instead of "stale" or "outdated" to describe the state where a particular partitions underlying representation in storage is not in sync with its software definition. This can be:

  • Because the underlying stored partition is missing
  • The code version of the asset has changed since the last time this partition was materialized.
  • An upstream partition has a new materialization that was not used to materialize the current partition.
  • Dependencies have changed
  • A direct upstream asset partition is unsynced. (The definition is recursive within some scope)

Internal discussion around this.

How I Tested These Changes

Unit tests

@schrockn
Copy link
Member Author

schrockn commented Mar 8, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @schrockn and the rest of your teammates on Graphite Graphite

@schrockn schrockn force-pushed the asset-graph-view-4 branch from 174f84d to 0593594 Compare March 8, 2024 12:11
@schrockn schrockn force-pushed the asset-graph-view-5 branch 2 times, most recently from 150b8b9 to 77bc6e3 Compare March 8, 2024 12:23
@schrockn schrockn marked this pull request as ready for review March 8, 2024 12:48
@schrockn schrockn force-pushed the asset-graph-view-4 branch from b8a1d06 to f838b6b Compare March 8, 2024 14:23
@schrockn schrockn force-pushed the asset-graph-view-5 branch 2 times, most recently from 980dd90 to 78fdda1 Compare March 8, 2024 14:52
@schrockn schrockn force-pushed the asset-graph-view-4 branch from f838b6b to 296d2a1 Compare March 9, 2024 12:27
@schrockn schrockn force-pushed the asset-graph-view-5 branch 3 times, most recently from 365fe53 to d8e1c5c Compare March 9, 2024 21:16
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 65c93d8 to a2696d5 Compare March 10, 2024 18:18
@schrockn schrockn force-pushed the asset-graph-view-5 branch from d8e1c5c to be0ef96 Compare March 10, 2024 18:18
@schrockn schrockn force-pushed the asset-graph-view-4 branch from a2696d5 to 2460929 Compare March 11, 2024 09:37
@schrockn schrockn force-pushed the asset-graph-view-5 branch from be0ef96 to e106b8f Compare March 11, 2024 09:37
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 2460929 to 49fb12b Compare March 11, 2024 17:27
@schrockn schrockn force-pushed the asset-graph-view-5 branch from e106b8f to 3e36fd4 Compare March 11, 2024 17:27
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 49fb12b to c7e13c3 Compare March 12, 2024 10:10
@schrockn schrockn force-pushed the asset-graph-view-5 branch from 3e36fd4 to 3cf56c4 Compare March 12, 2024 10:10
Copy link
Member Author

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abandoning this as we are going to redefine unsynced

@schrockn schrockn closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant