-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsynced status to AssetSlice #20358
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
174f84d
to
0593594
Compare
150b8b9
to
77bc6e3
Compare
b8a1d06
to
f838b6b
Compare
980dd90
to
78fdda1
Compare
f838b6b
to
296d2a1
Compare
365fe53
to
d8e1c5c
Compare
65c93d8
to
a2696d5
Compare
d8e1c5c
to
be0ef96
Compare
a2696d5
to
2460929
Compare
be0ef96
to
e106b8f
Compare
2460929
to
49fb12b
Compare
e106b8f
to
3e36fd4
Compare
49fb12b
to
c7e13c3
Compare
3e36fd4
to
3cf56c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abandoning this as we are going to redefine unsynced
Summary & Motivation
Adding the ability to interrogate the
AssetSlice
for its sync status.We are going to move to the term "unsynced" instead of "stale" or "outdated" to describe the state where a particular partitions underlying representation in storage is not in sync with its software definition. This can be:
Internal discussion around this.
How I Tested These Changes
Unit tests