Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic partitioning in AssetSlice #20355

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Mar 8, 2024

Summary & Motivation

Adding support for dynamic partitioning in the AssetSlice

How I Tested These Changes

BK

@schrockn
Copy link
Member Author

schrockn commented Mar 8, 2024

@schrockn schrockn force-pushed the asset-graph-view-4 branch from d779006 to 174f84d Compare March 8, 2024 10:37
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 174f84d to 0593594 Compare March 8, 2024 12:11
@schrockn schrockn force-pushed the asset-graph-view-3 branch from d3ecbbf to 14e6b97 Compare March 8, 2024 14:23
@schrockn schrockn force-pushed the asset-graph-view-4 branch from b8a1d06 to f838b6b Compare March 8, 2024 14:23
@schrockn schrockn force-pushed the asset-graph-view-3 branch from 14e6b97 to d73cb65 Compare March 9, 2024 12:27
@schrockn schrockn force-pushed the asset-graph-view-4 branch from f838b6b to 296d2a1 Compare March 9, 2024 12:27
@schrockn schrockn force-pushed the asset-graph-view-3 branch from d73cb65 to 109372a Compare March 10, 2024 18:18
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 65c93d8 to a2696d5 Compare March 10, 2024 18:18
@schrockn schrockn force-pushed the asset-graph-view-3 branch from 109372a to c8e57dd Compare March 11, 2024 09:36
@schrockn schrockn force-pushed the asset-graph-view-4 branch from a2696d5 to 2460929 Compare March 11, 2024 09:37
Copy link
Collaborator

@smackesey smackesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on error msg but otherwise lgtm

@schrockn schrockn force-pushed the asset-graph-view-3 branch from c8e57dd to 38c8b37 Compare March 11, 2024 17:27
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 2460929 to 49fb12b Compare March 11, 2024 17:27
@schrockn schrockn force-pushed the asset-graph-view-3 branch from 38c8b37 to 2cc13a9 Compare March 12, 2024 10:07
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 49fb12b to c7e13c3 Compare March 12, 2024 10:10
@schrockn schrockn force-pushed the asset-graph-view-3 branch from e23ea96 to 52bf7bd Compare March 12, 2024 10:38
@schrockn schrockn force-pushed the asset-graph-view-4 branch from c7e13c3 to 99119ec Compare March 12, 2024 10:38
@schrockn schrockn force-pushed the asset-graph-view-3 branch from 52bf7bd to 7e8c5cb Compare March 12, 2024 12:39
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 99119ec to 73ed0f2 Compare March 12, 2024 12:39
@schrockn schrockn force-pushed the asset-graph-view-3 branch from 7e8c5cb to 905ef8a Compare March 12, 2024 13:17
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 73ed0f2 to 73e54c2 Compare March 12, 2024 13:28
@schrockn schrockn force-pushed the asset-graph-view-3 branch from 905ef8a to 39ac36c Compare March 13, 2024 15:12
@schrockn schrockn force-pushed the asset-graph-view-4 branch from 73e54c2 to c50d9bb Compare March 13, 2024 15:12
@schrockn
Copy link
Member Author

schrockn commented Mar 13, 2024

Merge activity

  • Mar 13, 1:59 PM EDT: @schrockn started a stack merge that includes this pull request via Graphite.
  • Mar 13, 2:03 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 13, 2:04 PM EDT: @schrockn merged this pull request with Graphite.

@schrockn schrockn force-pushed the asset-graph-view-3 branch from 39ac36c to bbaf547 Compare March 13, 2024 18:00
Base automatically changed from asset-graph-view-3 to master March 13, 2024 18:02
@schrockn schrockn force-pushed the asset-graph-view-4 branch from c50d9bb to d327876 Compare March 13, 2024 18:03
@schrockn schrockn merged commit ce5fb59 into master Mar 13, 2024
1 check was pending
@schrockn schrockn deleted the asset-graph-view-4 branch March 13, 2024 18:04
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation

Adding support for dynamic partitioning in the AssetSlice

## How I Tested These Changes

BK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants