-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] [revamp] - Beefing up Vale #23754
Conversation
✅ Deploy Preview for dagsterapidocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-nrw479zfp-elementl.vercel.app Direct link to changed pages: |
I ran these new styles against the existing Here's my thoughts:
|
@PedramNavid Thanks for catching this - I was tinkering around and forgot to remove it.
I'll look into this. For SDA, are you talking about Software-defined Assets? If so, we shouldn't be using this acronym as we deprecated the term.
Agreed! I didn't know about the translation issue (the reason behind this rule), so I'll fix the headings. |
We don't translate our docs so we can also remove the rule if needed. If we deprecated SDAs lets add a replacement rule |
## Summary & Motivation This PR addresses comments in #23754 ## How I Tested These Changes
## Summary & Motivation This PR beefs up our Vale implementation with some custom rules and vocabularies. The README for this will be updated in a subsequent PR. ## How I Tested These Changes eyes, local
## Summary & Motivation This PR addresses comments in #23754 ## How I Tested These Changes
## Summary & Motivation This PR beefs up our Vale implementation with some custom rules and vocabularies. The README for this will be updated in a subsequent PR. ## How I Tested These Changes eyes, local
## Summary & Motivation This PR addresses comments in #23754 ## How I Tested These Changes
## Summary & Motivation Brings in #23754 and #23758 into the master branch for docs-beta styling. ## How I Tested These Changes --------- Co-authored-by: Erin Cochran <[email protected]>
Brings in #23754 and #23758 into the master branch for docs-beta styling. --------- Co-authored-by: Erin Cochran <[email protected]>
## Summary & Motivation Brings in #23754 and #23758 into the master branch for docs-beta styling. ## How I Tested These Changes --------- Co-authored-by: Erin Cochran <[email protected]>
Summary & Motivation
This PR beefs up our Vale implementation with some custom rules and vocabularies. The README for this will be updated in a subsequent PR.
How I Tested These Changes
eyes, local