[6/n][dagster-fivetran] Implement FivetranWorkspaceDefsLoader #25807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2024
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
Merged
This was referenced Nov 8, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
16e3497 to
aad712a
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
0e257e0 to
e0fb1eb
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
aad712a to
dc9a490
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
e0fb1eb to
77756ae
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
dc9a490 to
cfcd238
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
77756ae to
de7c6f3
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
cfcd238 to
916f3ea
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
de7c6f3 to
f12bbb7
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
916f3ea to
1d5bf36
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
f12bbb7 to
0c52d6a
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
1d5bf36 to
c407973
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
0c52d6a to
6126387
Compare
dpeng817
approved these changes
Nov 12, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-5
branch
from
c407973 to
4913f6e
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
2 times, most recently
from
29e9aa6 to
5383b60
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-6
branch
from
5383b60 to
86853f1
Compare
This was referenced Nov 13, 2024
Merged
This was referenced Nov 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR implements the
FivetranWorkspaceDefsLoaderto be used to load asset specs.account_idis added as a parameter toFivetranWorkspace- we need a unique ID for the Fivetran workspace to implementdefs_key.How I Tested These Changes
Updated unit tests