[dagster-fivetran] Use Fivetran translator instance in load specs fn and state-backed defs #26133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
Merged
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
This was referenced Nov 25, 2024
schrockn
approved these changes
Nov 25, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
3 times, most recently
from
ebca057 to
4f7cd9a
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
4f7cd9a to
5f1b3f8
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
c4d02f2 to
936f4f0
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
5f1b3f8 to
f78ad58
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
936f4f0 to
5956c55
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
f78ad58 to
44865a4
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
5956c55 to
51a001f
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
44865a4 to
a83dfc6
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
51a001f to
acce2c7
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
a83dfc6 to
ebe8457
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
acce2c7 to
2a2ce09
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
ebe8457 to
748298f
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
2a2ce09 to
d2fa78b
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
748298f to
538348f
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
d2fa78b to
67d0fcd
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-10
branch
from
538348f to
e97963d
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
67d0fcd to
6cf70a0
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
6cf70a0 to
47cb47a
Compare
…and state-backed defs
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
from
47cb47a to
79f0f78
Compare
maximearmstrong
deleted the
maxime/use-translator-instance-in-load-fivetran-asset-specs
branch
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…and state-backed defs (dagster-io#26133) ## Summary & Motivation Updates load_fivetran_asset_specs() and state-backed definitions to accept an instance of `DagsterFivetranTranslator`. See more about the motivation in the original thread [here](dagster-io#25944 (comment)). ## How I Tested These Changes Additional unit tests to test custom translators with BK ## Changelog [dagster-fivetran] `load_fivetran_asset_specs` is updated to accept an instance of `DagsterFivetranTranslator` or custom subclass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates load_fivetran_asset_specs() and state-backed definitions to accept an instance of
DagsterFivetranTranslator.See more about the motivation in the original thread here.
How I Tested These Changes
Additional unit tests to test custom translators with BK
Changelog
[dagster-fivetran]
load_fivetran_asset_specsis updated to accept an instance ofDagsterFivetranTranslatoror custom subclass.