-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-fivetran] Implement get_columns_config_for_table in FivetranClient #26181
Merged
maximearmstrong
merged 1 commit into
master
from
maxime/implement-get-columns-for-table-fivetran-client
Dec 9, 2024
Merged
[dagster-fivetran] Implement get_columns_config_for_table in FivetranClient #26181
maximearmstrong
merged 1 commit into
master
from
maxime/implement-get-columns-for-table-fivetran-client
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData
to FivetranConnectorTableProps
method
#25797
Merged
Merged
This was referenced Nov 27, 2024
dpeng817
approved these changes
Dec 5, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
December 5, 2024 18:40
b0e8961
to
c94dc6b
Compare
maximearmstrong
force-pushed
the
maxime/implement-get-columns-for-table-fivetran-client
branch
from
December 5, 2024 18:41
faa06ab
to
2e55283
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
December 5, 2024 20:13
c94dc6b
to
36e9da9
Compare
maximearmstrong
force-pushed
the
maxime/implement-get-columns-for-table-fivetran-client
branch
from
December 5, 2024 20:14
2e55283
to
19a4794
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
December 5, 2024 20:46
36e9da9
to
99e73bd
Compare
maximearmstrong
force-pushed
the
maxime/implement-get-columns-for-table-fivetran-client
branch
from
December 5, 2024 20:47
19a4794
to
cefb005
Compare
maximearmstrong
force-pushed
the
maxime/implement-get-columns-for-table-fivetran-client
branch
from
December 5, 2024 21:14
cefb005
to
d7f0a8a
Compare
maximearmstrong
force-pushed
the
maxime/implement-get-columns-for-table-fivetran-client
branch
from
December 9, 2024 17:57
d7f0a8a
to
8a0b091
Compare
maximearmstrong
deleted the
maxime/implement-get-columns-for-table-fivetran-client
branch
December 9, 2024 18:09
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…Client (dagster-io#26181) ## Summary & Motivation Implements `get_columns_config_for_table` with tests, to be used dagster-io#26110. ## How I Tested These Changes Additional test with BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Implements
get_columns_config_for_table
with tests, to be used #26110.How I Tested These Changes
Additional test with BK