Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-fivetran] Implement get_columns_config_for_table in FivetranClient #26181

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Nov 27, 2024

Summary & Motivation

Implements get_columns_config_for_table with tests, to be used #26110.

How I Tested These Changes

Additional test with BK

This was referenced Nov 27, 2024
Copy link
Contributor Author

maximearmstrong commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maximearmstrong maximearmstrong force-pushed the maxime/rework-fivetran-11 branch from b0e8961 to c94dc6b Compare December 5, 2024 18:40
@maximearmstrong maximearmstrong force-pushed the maxime/implement-get-columns-for-table-fivetran-client branch from faa06ab to 2e55283 Compare December 5, 2024 18:41
@maximearmstrong maximearmstrong force-pushed the maxime/rework-fivetran-11 branch from c94dc6b to 36e9da9 Compare December 5, 2024 20:13
@maximearmstrong maximearmstrong force-pushed the maxime/implement-get-columns-for-table-fivetran-client branch from 2e55283 to 19a4794 Compare December 5, 2024 20:14
@maximearmstrong maximearmstrong force-pushed the maxime/rework-fivetran-11 branch from 36e9da9 to 99e73bd Compare December 5, 2024 20:46
@maximearmstrong maximearmstrong force-pushed the maxime/implement-get-columns-for-table-fivetran-client branch from 19a4794 to cefb005 Compare December 5, 2024 20:47
Base automatically changed from maxime/rework-fivetran-11 to master December 5, 2024 21:13
@maximearmstrong maximearmstrong force-pushed the maxime/implement-get-columns-for-table-fivetran-client branch from cefb005 to d7f0a8a Compare December 5, 2024 21:14
@maximearmstrong maximearmstrong force-pushed the maxime/implement-get-columns-for-table-fivetran-client branch from d7f0a8a to 8a0b091 Compare December 9, 2024 17:57
@maximearmstrong maximearmstrong merged commit dcabca7 into master Dec 9, 2024
1 check passed
@maximearmstrong maximearmstrong deleted the maxime/implement-get-columns-for-table-fivetran-client branch December 9, 2024 18:09
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
…Client (dagster-io#26181)

## Summary & Motivation

Implements `get_columns_config_for_table` with tests, to be used dagster-io#26110.

## How I Tested These Changes

Additional test with BK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants