[module-loaders] Use new loader code in checks loaders #26514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpeng817
changed the title
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-i902ewhyw-elementl.vercel.app Direct link to changed pages: |
dpeng817
force-pushed
the
dpeng817/handle_attribute_mapping
branch
from
46d0738 to
b5ea375
Compare
dpeng817
force-pushed
the
dpeng817/use_new_loader_in_checks
branch
from
d6b7692 to
1e84402
Compare
OwenKephart
requested changes
Dec 16, 2024
python_modules/dagster/dagster/_core/definitions/load_assets_from_modules.py
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/load_assets_from_modules.py
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/load_assets_from_modules.py
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/load_assets_from_modules.py
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/load_assets_from_modules.py
Show resolved
Hide resolved
This was referenced Dec 16, 2024
OwenKephart
approved these changes
Dec 16, 2024
This was referenced Dec 16, 2024
[module-loaders] Genericize object list functionality to take in all sensors, jobs, schedules
#26545
Merged
dpeng817
force-pushed
the
dpeng817/handle_attribute_mapping
branch
from
b5ea375 to
54dab1e
Compare
dpeng817
force-pushed
the
dpeng817/use_new_loader_in_checks
branch
from
1e84402 to
aa8efe8
Compare
dpeng817
force-pushed
the
dpeng817/handle_attribute_mapping
branch
from
54dab1e to
1efb94c
Compare
dpeng817
force-pushed
the
dpeng817/use_new_loader_in_checks
branch
from
aa8efe8 to
0309dba
Compare
dpeng817
changed the title
dpeng817
force-pushed
the
dpeng817/handle_attribute_mapping
branch
from
1efb94c to
29c4c40
Compare
dpeng817
force-pushed
the
dpeng817/use_new_loader_in_checks
branch
from
0309dba to
5be4d04
Compare
dpeng817
force-pushed
the
dpeng817/handle_attribute_mapping
branch
from
29c4c40 to
84a8e05
Compare
dpeng817
force-pushed
the
dpeng817/use_new_loader_in_checks
branch
from
5be4d04 to
292e31e
Compare
Base automatically changed from
dpeng817/handle_attribute_mapping
to
dpeng817/delete_extra_source_assets
December 18, 2024 18:46
dpeng817
merged commit 292e31e
into
dpeng817/delete_extra_source_assets
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the new asset loading internal APIs under the hood on the checks loaders. This allows us to actually delete the old
prefix_assetsmethod, which was still in use here.A lot of the added code lines here are explicit coercion to "asset checks definitions" from assetsdefinitions after they have had attributes replaced. I wonder if this is actually necessary and can't be removed in another PR which handles that case holistically.
But now at least everything is using the same stuff under the hood, and we're able to remove this tangled mess of helper methods.