[module-loaders] Split loader file into multiple different files #26533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 17, 2024
[module-loaders] Genericize object list functionality to take in all sensors, jobs, schedules
#26545
Merged
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
747dd4c to
d794181
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
5e70be8 to
37ba786
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
d794181 to
0f54413
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
37ba786 to
c2b5a86
Compare
dpeng817
changed the title
OwenKephart
approved these changes
Dec 18, 2024
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
0f54413 to
06866ca
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
c2b5a86 to
859fe49
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
06866ca to
b5ffe39
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
859fe49 to
ea424e1
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
b5ffe39 to
43a69bb
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
ea424e1 to
fe234d6
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
43a69bb to
b1163c0
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
fe234d6 to
a6edd3c
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
b1163c0 to
fbc3842
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
a6edd3c to
c63c327
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
fbc3842 to
35a9591
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
c63c327 to
96a7aab
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
35a9591 to
3306b93
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
96a7aab to
9e56100
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
3306b93 to
6906f5c
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
9e56100 to
143aa7b
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
6906f5c to
10d53b0
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
143aa7b to
67ee4a3
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
10d53b0 to
4f5d461
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
67ee4a3 to
370277b
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
4f5d461 to
5040516
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
370277b to
349e3bd
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
5040516 to
c3575b9
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
349e3bd to
a10d824
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
c3575b9 to
cf18a2a
Compare
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
a10d824 to
b5065bf
Compare
Base automatically changed from
dpeng817/file_and_test_refactor
to
dpeng817/delete_extra_source_assets
December 19, 2024 16:41
dpeng817
force-pushed
the
dpeng817/split_load_file
branch
from
b5065bf to
41ec0ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The load_assets_from_x file was getting quite large, split it up into different files for easier reuse across the module.