[module-loaders] File and test refactor #26532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 17, 2024
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-fybsvgplh-elementl.vercel.app Direct link to changed pages: |
This was referenced Dec 17, 2024
[module-loaders] Genericize object list functionality to take in all sensors, jobs, schedules
#26545
Merged
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
09effd3 to
1c471fe
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
747dd4c to
d794181
Compare
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
1c471fe to
d4250b7
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
d794181 to
0f54413
Compare
dpeng817
changed the title
OwenKephart
approved these changes
Dec 18, 2024
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
d4250b7 to
395778b
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
0f54413 to
06866ca
Compare
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
395778b to
d43be3f
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
06866ca to
b5ffe39
Compare
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
d43be3f to
9239b46
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
b5ffe39 to
43a69bb
Compare
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
9239b46 to
6ce58d8
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
43a69bb to
b1163c0
Compare
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
6ce58d8 to
1e90746
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
b1163c0 to
fbc3842
Compare
dpeng817
force-pushed
the
dpeng817/consolidate_cacheable
branch
from
1e90746 to
9120c45
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
2 times, most recently
from
35a9591 to
3306b93
Compare
dpeng817
changed the base branch from
dpeng817/consolidate_cacheable
to
dpeng817/explicit_check_with_attributes
dpeng817
force-pushed
the
dpeng817/explicit_check_with_attributes
branch
from
a5f5196 to
0cd44d7
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
3306b93 to
6906f5c
Compare
dpeng817
force-pushed
the
dpeng817/explicit_check_with_attributes
branch
from
0cd44d7 to
36b9068
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
6906f5c to
10d53b0
Compare
dpeng817
force-pushed
the
dpeng817/explicit_check_with_attributes
branch
from
36b9068 to
02a6eb4
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
10d53b0 to
4f5d461
Compare
dpeng817
force-pushed
the
dpeng817/explicit_check_with_attributes
branch
from
02a6eb4 to
7b0e692
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
4f5d461 to
5040516
Compare
Base automatically changed from
dpeng817/explicit_check_with_attributes
to
dpeng817/delete_extra_source_assets
December 19, 2024 16:15
dpeng817
force-pushed
the
dpeng817/delete_extra_source_assets
branch
from
472a759 to
1b50ebe
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
5040516 to
c3575b9
Compare
dpeng817
force-pushed
the
dpeng817/delete_extra_source_assets
branch
from
1b50ebe to
5ddc747
Compare
dpeng817
force-pushed
the
dpeng817/file_and_test_refactor
branch
from
c3575b9 to
cf18a2a
Compare
dpeng817
merged commit fb83dda
into
dpeng817/delete_extra_source_assets
1 of 2 checks passed
dpeng817
added a commit
that referenced
this pull request
Dec 19, 2024
## Summary & Motivation Consolidate module loader code and tests into a single directory for easier reuse between them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Consolidate module loader code and tests into a single directory for easier reuse between them.