-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port HIL-SERL #565
Open
michel-aractingi
wants to merge
26
commits into
main
Choose a base branch
from
user/michel-aractingi/2024-11-27-port-hil-serl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Port HIL-SERL #565
michel-aractingi
wants to merge
26
commits into
main
from
user/michel-aractingi/2024-11-27-port-hil-serl
+2,546
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Ritchie <[email protected]> Co-authored-by: resolver101757 <[email protected]> Co-authored-by: Jannik Grothusen <[email protected]> Co-authored-by: Remi <[email protected]> Co-authored-by: Michel Aractingi <[email protected]>
…licy on the robot (#541) Co-authored-by: Yoel <[email protected]>
Co-authored-by: Simon Alibert <[email protected]>
Co-authored-by: Remi <[email protected]>
Co-authored-by: Yoel <[email protected]>
Co-authored-by: KeWang1017 <[email protected]>
michel-aractingi
force-pushed
the
user/michel-aractingi/2024-11-27-port-hil-serl
branch
from
December 17, 2024 15:22
3d7e74d
to
def42ff
Compare
…ing logic - Added `num_subsample_critics`, `critic_target_update_weight`, and `utd_ratio` to SACConfig. - Implemented target entropy calculation in SACPolicy if not provided. - Introduced subsampling of critics to prevent overfitting during updates. - Updated temperature loss calculation to use the new target entropy. - Added comments for future UTD update implementation. These changes improve the flexibility and performance of the SAC implementation.
@michel-aractingi Hi, Can you elaborate more on how to test hil-serl ? During step 1, for instance a cube grasping task, should we record failure samples on purpose or reward transition from 0 to 1 after successful grasping is enough ? What should be the expected behavior in step 3 ("eval on the robot and test human interventions"), would this algorithm perform better than ACT ? Thanks. |
…s & check script (#578)
…n handling - Updated action selection to use distribution sampling and log probabilities for better stochastic behavior. - Enhanced standard deviation clamping to prevent extreme values, ensuring stability in policy outputs. - Cleaned up code by removing unnecessary comments and improving readability. These changes aim to refine the SAC implementation, enhancing its robustness and performance during training and inference.
- Updated standard deviation parameterization in SACConfig to 'softplus' with defined min and max values for improved stability. - Modified action sampling in SACPolicy to use reparameterized sampling, ensuring better gradient flow and log probability calculations. - Cleaned up log probability calculations in TanhMultivariateNormalDiag for clarity and efficiency. - Increased evaluation frequency in YAML configuration to 50000 for more efficient training cycles. These changes aim to enhance the robustness and performance of the SAC implementation during training and inference.
…d stability - Updated SACConfig to replace standard deviation parameterization with log_std_min and log_std_max for better control over action distributions. - Modified SACPolicy to streamline action selection and log probability calculations, enhancing stochastic behavior. - Removed deprecated TanhMultivariateNormalDiag class to simplify the codebase and improve maintainability. These changes aim to enhance the robustness and performance of the SAC implementation during training and inference.
michel-aractingi
force-pushed
the
user/michel-aractingi/2024-11-27-port-hil-serl
branch
from
December 30, 2024 13:47
bd8d252
to
35de91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Adds HIL-SERL to the policies of LeRobot in
lerobot/common/policies/hilserl/
.What this PR contains so far
lerobot/scripts/control_robot.py
->record
function.lerobot/common/policies/hilserl/classifier
.lerobot/scripts/train_hilserl_classifier.py
lerobot/scripts/eval_on_robot.py
we added the ability to do policy rollouts on the real robot. Moreover, you also have the ability to stop the policy actions bieng rolled-out and take over if you have a leader arm.How to test:
References: