Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametrise tolerance_s in visualize_dataset scripts #716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eaa3
Copy link

@eaa3 eaa3 commented Feb 11, 2025

What this does

Hi guys, this is a simple PR adding an optional argument for the tolerance_s parameter when visualising a LeRobotDataset.
This should make the visualisation a bit more flexible if you want to relax that threshold when visualising test data, etc.

Examples:

Title Label
Improve visualization script (⚡️ Minor improvement)

How it was tested

Explain/show how you tested your changes.

Examples:

  • You can quickly try by running the examples bellow.

How to checkout & try? (for the reviewer)

Provide a simple way for the reviewer to try out your changes.

Examples:

python -m lerobot.scripts.visualize_dataset --episode-index 0  --repo-id lerobot/pushT --tolerance-s 0.1

Example without tolerance parameter being chosen (default matches LeRobotDataset tolarance_s=1e-4)

python -m lerobot.scripts.visualize_dataset --episode-index 0  --repo-id lerobot/pushT

Same is valid for the html visualiser:

python -m lerobot.scripts.visualize_dataset_html --repo-id lerobot/pushT --port 9090 --tolerance-s 0.1

Example without tolerance parameter being chosen (default matches LeRobotDataset tolarance_s=1e-4)

python -m lerobot.scripts.visualize_dataset_html --repo-id lerobot/pushT --port 9090

@eaa3 eaa3 marked this pull request as ready for review February 11, 2025 17:37
@eaa3
Copy link
Author

eaa3 commented Feb 11, 2025

cc: @aliberts @Cadene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant