Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xs: Add error message in homepage of dataset visualizer. (⚡️ UX Improvement) #756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jeerhz
Copy link

@Jeerhz Jeerhz commented Feb 20, 2025

What this does

We verify the dataset endpoint before redirecting. When a user enters a dataset ID, a HEAD request is sent to check for the dataset’s existence. If the dataset isn’t found or if there is something wrong, an error message is shown:

How it was tested

  • test_visualize_dataset is skipped.

How to checkout & try? (for the reviewer)

  1. Start the development server.
  2. Navigate to the homepage.
  3. Enter a valid or invalid dataset ID in the input field and press Enter

Before

Capture d’écran 2025-02-20 à 17 42 36

After

Capture d’écran 2025-02-20 à 17 43 15

cc: @Pierre-LouisBJT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant