AWS full tests

[mirpedrol]

The github action to launch the pipeline with full tests in AWS with the Seqera platform has some issues right now:

• The trigger pull_request doesn't make sense as it's always skipped. The action will only run if there are two reviews or if it's manually dispatched. This can be removed.
• The action is launching pipelines with an unexisting git sha.
• The action should launch the pipelines with dev
• At the same time, add back the trigger to run the tests after the PR is merged or a release is done, to launch the pipeline with the last version and be able to see these results in the nf-core website.

[ewels]

Agree - sounds like it's suffered a bit of drift since it was first written. My memory from when we added it was that it'd run in two circumstances:

• On master after merge, manually dispatched before the release is done
• Automatically on release, if the above was forgotten (so that the results will show on the website).

I think that the PR stuff was probably added in later, as folks weren't running it manually and failures would show up post-release. The idea was that -profile test would run on AWS but not the more expensive test_full I think? But test_full does quite often find errors that the small test data doesn't.

Now that we are in a happy place with AWS credits, I think that it's a good idea to test on PRs and release as you say @mirpedrol

So to confirm, you're suggesting removing these lines:

tools/nf_core/pipeline-template/.github/workflows/awsfulltest.yml

Lines 7 to 10 in 52e8109

	pull_request:
	branches:
	- main
	- master

But keeping these?

tools/nf_core/pipeline-template/.github/workflows/awsfulltest.yml

Lines 12 to 13 in 52e8109

	pull_request_review:
	types: [submitted]

Note that main needs to be added as an option here:

tools/nf_core/pipeline-template/.github/workflows/awsfulltest.yml

Lines 18 to 19 in 52e8109

	# run only if the PR is approved by at least 2 reviewers and against the master branch or manually triggered
	if: github.repository == '{{ name }}' && github.event.review.state == 'approved' && github.event.pull_request.base.ref == 'master' || github.event_name == 'workflow_dispatch'

I don't really understand the bit about launching pipelines from dev 🤔 You mean this line?

tools/nf_core/pipeline-template/.github/workflows/awsfulltest.yml

Line 55 in 52e8109

revision: ${{ github.sha }}

Is this not doing the correct thing - launching from the PR merge dev if in a PR and launching from the latest commit when on release?

[mirpedrol]

I don't really understand the bit about launching pipelines from dev 🤔 You mean this line?

Yes, sorry, there was a mistake in my text. Currently, this action is launching the pipelines from a git sha, which is the merge commit, and thus it doesn't exist in the pipeline.