-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template: Run awsfulltest after release, and with dev revision on PRs to master #3485
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can then remove the approval checking steps. they were anyway too buggy.
If we remove this the tests will run two times, one when the first review is approved and submitted and one when the second one is submitted. Is this a no go? or we are fine with it? |
better then a wonky check before. but maybe we can check if there is already something in the S3 bucket and only run if it is empty or something like that? |
I have removed the check for now. |
Close #3462