Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RO-crate content appear in the nf-core lint warning if there is a TODO #3493

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from

Conversation

ningyuxin1999
Copy link

@ningyuxin1999 ningyuxin1999 commented Mar 17, 2025

Changes:

  1. The RO-crate-metadata.json is ignored in linting
  2. Added a test script nf_core/pipelines/lint/rocrate_readme_sync.py for synchronizing the content of ROcrate metadata and the repo README.

The warning message mentioned here disappears when you create a new pipeline without deleting the TODO commands. But I still wonder where I should add the --fix flag so that the use can decide whether they want to synchronize the metadata with the readme file.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a couple of comments, otherwise is looking good!

@ningyuxin1999 ningyuxin1999 marked this pull request as ready for review March 25, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

2 participants