-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to dart-sass #5216
Migrate to dart-sass #5216
Conversation
Thanks for your interest in palantir/blueprint, @pgoldberg! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
d221437
to
2974da5
Compare
Looks like you made some good progress here. I'm bumping stylelint & stylelint-config-palantir in #5217, so you should get lint passing after that merges. |
New stylelint config has a bug, see palantir/stylelint-config-palantir#58. I've worked around it with a config override for now. |
7c963d3
to
38c7c91
Compare
Fixed those in the last commit, although it's not nearly as nice as just extending the compound selectors Tested with dark mode and intents (comparing against blueprintjs.com) to confirm it still works correctly in those circumstances |
2b4f912
to
fb0642d
Compare
fb0642d
to
9561284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, the menu item styles mixin implementation looks good 👍
Fixes #4032, fixes #4751
Changes proposed in this pull request:
node-sass
todart-sass
/
division operators with*
ormath.div()
where appropriateReviewers should focus on:
No regressions
Screenshot