-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPS semantic component #2000
Add GPS semantic component #2000
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
+ Coverage 89.35% 89.40% +0.05%
==========================================
Files 130 132 +2
Lines 14576 14663 +87
Branches 1258 1258
==========================================
+ Hits 13024 13110 +86
+ Misses 1088 1085 -3
- Partials 464 468 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look very good. Good job @Wiktor-99
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never used GPS in the context of ROS. But having a look at the message definition, shouldn't we add also NavSatStatus
to the component?
int8 status
uint16 service
I think this can be useful and every receiver has this as output, but is maybe depending on the used protocol like NMEA, ubx, ..
The status is already there. I'm not sure about service. I don't know if it can be dynamically updated, I'll check it. |
@christophfroehlich I added service filling in the PR |
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through all the changes. This is good work
LGTM
165c3c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/gps_sensor.hpp
Outdated
Show resolved
Hide resolved
a052502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the good work! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the follow ups!
Adding initial version of GPSSensor semantic components. I decided to add two with covariance interface and w/o interface.
It'll be followed by GPS broadcaster in ros2_controllers.
I'm open too all suggestions.