Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPS semantic component #2000

Conversation

Wiktor-99
Copy link
Contributor

Adding initial version of GPSSensor semantic components. I decided to add two with covariance interface and w/o interface.

It'll be followed by GPS broadcaster in ros2_controllers.

I'm open too all suggestions.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (f8c03cc) to head (c4cf0e0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
+ Coverage   89.35%   89.40%   +0.05%     
==========================================
  Files         130      132       +2     
  Lines       14576    14663      +87     
  Branches     1258     1258              
==========================================
+ Hits        13024    13110      +86     
+ Misses       1088     1085       -3     
- Partials      464      468       +4     
Flag Coverage Δ
unittests 89.40% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...terface/include/semantic_components/gps_sensor.hpp 100.00% <100.00%> (ø)
controller_interface/test/test_gps_sensor.cpp 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look very good. Good job @Wiktor-99

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never used GPS in the context of ROS. But having a look at the message definition, shouldn't we add also NavSatStatus to the component?

int8 status
uint16 service

I think this can be useful and every receiver has this as output, but is maybe depending on the used protocol like NMEA, ubx, ..

@Wiktor-99
Copy link
Contributor Author

The status is already there. I'm not sure about service. I don't know if it can be dynamically updated, I'll check it.

@Wiktor-99
Copy link
Contributor Author

@christophfroehlich I added service filling in the PR

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

saikishor
saikishor previously approved these changes Jan 14, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through all the changes. This is good work

LGTM

saikishor
saikishor previously approved these changes Jan 14, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wiktor-99 Wiktor-99 requested a review from Maverobot January 19, 2025 20:42
Copy link
Member

@Maverobot Maverobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the good work! :)

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the follow ups!

@christophfroehlich christophfroehlich merged commit d4139b7 into ros-controls:master Jan 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants