Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW Interface] Use new handle API inside the hardware components #2092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

Use new handle API inside the hardware components to be sure that you always set and retrieve value

@saikishor saikishor marked this pull request as ready for review March 4, 2025 21:01
@saikishor saikishor changed the title [HWComponentInterface] Use new handle API inside the hardware components [HW Interface] Use new handle API inside the hardware components Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.53%. Comparing base (3aa38b0) to head (fcda603).

Files with missing lines Patch % Lines
.../include/hardware_interface/actuator_interface.hpp 80.95% 2 Missing and 2 partials ⚠️
...ce/include/hardware_interface/system_interface.hpp 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
- Coverage   89.54%   89.53%   -0.01%     
==========================================
  Files         139      139              
  Lines       15125    15160      +35     
  Branches     1283     1287       +4     
==========================================
+ Hits        13543    13574      +31     
+ Misses       1096     1095       -1     
- Partials      486      491       +5     
Flag Coverage Δ
unittests 89.53% <84.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re_interface/include/hardware_interface/handle.hpp 86.25% <100.00%> (+2.25%) ⬆️
...ce/include/hardware_interface/sensor_interface.hpp 96.29% <100.00%> (+0.09%) ⬆️
.../include/hardware_interface/actuator_interface.hpp 93.50% <80.95%> (-2.21%) ⬇️
...ce/include/hardware_interface/system_interface.hpp 85.63% <80.95%> (-1.25%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CM catches the exceptions, right?

@saikishor
Copy link
Member Author

LGTM. The CM catches the exceptions, right?

Yes! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants