-
Notifications
You must be signed in to change notification settings - Fork 344
Supress the deprecation warnings of the hardware_interface API #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supress the deprecation warnings of the hardware_interface API #2223
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2223 +/- ##
==========================================
- Coverage 89.14% 88.93% -0.21%
==========================================
Files 141 143 +2
Lines 16168 16409 +241
Branches 1386 1421 +35
==========================================
+ Hits 14413 14594 +181
- Misses 1227 1265 +38
- Partials 528 550 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
We should get it into jazzy too, there's too much spamming as-is. |
#pragma GCC diagnostic push | ||
#pragma GCC diagnostic ignored "-Wdeprecated-declarations" | ||
#include "hardware_interface/handle.hpp" | ||
#pragma GCC diagnostic pop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be this is not needed. Let me check this afternoon and confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be cleaning these up in rolling/kilted anyways soon, let's move
With this PR, we are also changing the transmission handles. Earlier we were using the hardware_interface Handle and now we are using an older implementation with only variable reference. This way we can safely use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, thanks for the cleanup <3
(cherry picked from commit b3ef6d8)
The changes in this PR should suppress the deprecation warnings that are printed on compilation, There are some deprecations from
hardware_interface
package and a lot from the transmission_interfaces package (which needs to be addressed in a different PR)