-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify return types of static constructors for AutomationCondition #25184
Simplify return types of static constructors for AutomationCondition #25184
Conversation
f8d9617
to
4deb33e
Compare
db415a9
to
5459582
Compare
4deb33e
to
7010afc
Compare
5459582
to
4228091
Compare
7010afc
to
3cb2753
Compare
4228091
to
dd75b1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives us more option value so I think this is fine.
Note that I don't think the primary benefit here is simplicity but flexibility in implemenation. We could theorectically change the class of returned things without changing the type signature. There is a definite downside as it hides information from the user.
3cb2753
to
6956152
Compare
dd75b1f
to
664fef4
Compare
6956152
to
5edfb96
Compare
664fef4
to
b95e5a6
Compare
5edfb96
to
83506d8
Compare
b95e5a6
to
c805a1c
Compare
83506d8
to
177125c
Compare
c805a1c
to
be334be
Compare
177125c
to
cad8dd2
Compare
be334be
to
9d1759a
Compare
cad8dd2
to
f8c1d2c
Compare
9d1759a
to
5e750b4
Compare
f8c1d2c
to
bd71cf4
Compare
5e750b4
to
43c11a2
Compare
bd71cf4
to
19e3e9e
Compare
43c11a2
to
4bf0c8a
Compare
4bf0c8a
to
47d95a6
Compare
Summary & Motivation
As title. These return types were overly-specific. We have some subclasses that support additional methods, but most do not. To keep things more comprehensible for users that are seeing these types, use the least specific type possible in these cases.
How I Tested These Changes
Changelog
NOCHANGELOG