[1.9] Add automation_condition to observable_source_asset #25344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
fdd6922 to
7785aab
Compare
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
1ebe066 to
72af2ad
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
7785aab to
51de49f
Compare
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
72af2ad to
153df0d
Compare
alangenfeld
approved these changes
Oct 22, 2024
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
51de49f to
3101c46
Compare
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
153df0d to
858cde1
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
3101c46 to
7dc3271
Compare
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
858cde1 to
93d0b9b
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
7dc3271 to
c63e190
Compare
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
93d0b9b to
22f6c55
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
c63e190 to
05fa987
Compare
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
22f6c55 to
0d80191
Compare
OwenKephart
changed the base branch from
10-10-create_default_automation_condition_sensor_in_definitions_object
to
graphite-base/25344
This reverts commit e9c592034f7b10e0a4b4f4a1212ab442847435a6.
OwenKephart
force-pushed
the
10-17-add-automation-condition-to-observable-source-asset
branch
from
0d80191 to
12289e8
Compare
OwenKephart
deleted the
10-17-add-automation-condition-to-observable-source-asset
branch
Grzyblon
pushed a commit
to Grzyblon/dagster
that referenced
this pull request
Oct 26, 2024
…#25344) ## Summary & Motivation As title -- just needed to wire this up, the system already supported this nicely. Also took the opportunity to mark the deprecated APIs as deprecated. ## How I Tested These Changes ## Changelog The `@observable_source_asset` decorator now supports an `automation_condition` argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title -- just needed to wire this up, the system already supported this nicely. Also took the opportunity to mark the deprecated APIs as deprecated.
How I Tested These Changes
Changelog
The
@observable_source_assetdecorator now supports anautomation_conditionargument.