-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove description property, make names more descriptive #25186
Merged
OwenKephart
merged 1 commit into
master
from
10-10-remove_description_property_make_names_more_descriptive
Oct 15, 2024
Merged
Remove description property, make names more descriptive #25186
OwenKephart
merged 1 commit into
master
from
10-10-remove_description_property_make_names_more_descriptive
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 10, 2024 16:45
039cff8
to
aced9dd
Compare
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 10, 2024 17:30
db415a9
to
5459582
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 10, 2024 17:30
aced9dd
to
1357a85
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 10, 2024 19:40
5459582
to
4228091
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 10, 2024 19:40
1357a85
to
4491ce3
Compare
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 11, 2024 00:30
4228091
to
dd75b1f
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 00:30
4491ce3
to
1efdac9
Compare
This was referenced Oct 11, 2024
schrockn
approved these changes
Oct 11, 2024
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 11, 2024 17:17
dd75b1f
to
664fef4
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 17:18
1efdac9
to
791df56
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 11, 2024 19:45
664fef4
to
b95e5a6
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 19:46
791df56
to
904d371
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 11, 2024 22:25
b95e5a6
to
c805a1c
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 22:25
904d371
to
0f16ffb
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 14, 2024 16:51
c805a1c
to
be334be
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 14, 2024 16:51
0f16ffb
to
f463f7f
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 14, 2024 17:03
be334be
to
9d1759a
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 14, 2024 17:03
f463f7f
to
776c557
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 15, 2024 17:32
9d1759a
to
5e750b4
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 17:32
776c557
to
1dfdb5d
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 15, 2024 17:54
5e750b4
to
43c11a2
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 17:55
1dfdb5d
to
e72ffda
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 15, 2024 18:51
43c11a2
to
4bf0c8a
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 18:51
e72ffda
to
5d9eb60
Compare
OwenKephart
force-pushed
the
10-10-simply_return_types_of_static_constructors
branch
from
October 15, 2024 19:52
4bf0c8a
to
47d95a6
Compare
Base automatically changed from
10-10-simply_return_types_of_static_constructors
to
master
October 15, 2024 19:54
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 19:54
5d9eb60
to
0628cc4
Compare
OwenKephart
deleted the
10-10-remove_description_property_make_names_more_descriptive
branch
October 15, 2024 19:56
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The
description
property is a holdover from the old UI flow, and is not rendered in the new UI. Therefore, having it be specified on a bunch of built in conditions was a waste. This updates the name properties to be more descriptive (containing the relevant properties), which allows them to be represented in the UI.How I Tested These Changes
Changelog
NOCHANGELOG