Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove description property, make names more descriptive #25186

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

The description property is a holdover from the old UI flow, and is not rendered in the new UI. Therefore, having it be specified on a bunch of built in conditions was a waste. This updates the name properties to be more descriptive (containing the relevant properties), which allows them to be represented in the UI.

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 039cff8 to aced9dd Compare October 10, 2024 16:45
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from db415a9 to 5459582 Compare October 10, 2024 17:30
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from aced9dd to 1357a85 Compare October 10, 2024 17:30
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 5459582 to 4228091 Compare October 10, 2024 19:40
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 1357a85 to 4491ce3 Compare October 10, 2024 19:40
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 4228091 to dd75b1f Compare October 11, 2024 00:30
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 4491ce3 to 1efdac9 Compare October 11, 2024 00:30
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from dd75b1f to 664fef4 Compare October 11, 2024 17:17
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 1efdac9 to 791df56 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 664fef4 to b95e5a6 Compare October 11, 2024 19:45
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 791df56 to 904d371 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from b95e5a6 to c805a1c Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 904d371 to 0f16ffb Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from c805a1c to be334be Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 0f16ffb to f463f7f Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from be334be to 9d1759a Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from f463f7f to 776c557 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 9d1759a to 5e750b4 Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 776c557 to 1dfdb5d Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 5e750b4 to 43c11a2 Compare October 15, 2024 17:54
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 1dfdb5d to e72ffda Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 43c11a2 to 4bf0c8a Compare October 15, 2024 18:51
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from e72ffda to 5d9eb60 Compare October 15, 2024 18:51
Copy link
Contributor Author

OwenKephart commented Oct 15, 2024

Merge activity

  • Oct 15, 3:52 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 3:55 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 3:56 PM EDT: A user merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 10-10-simply_return_types_of_static_constructors branch from 4bf0c8a to 47d95a6 Compare October 15, 2024 19:52
Base automatically changed from 10-10-simply_return_types_of_static_constructors to master October 15, 2024 19:54
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 5d9eb60 to 0628cc4 Compare October 15, 2024 19:54
@OwenKephart OwenKephart merged commit 564cd78 into master Oct 15, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 10-10-remove_description_property_make_names_more_descriptive branch October 15, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants