Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create backfill_in_progress AutomationCondition #25190

Merged

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

As title. This converts the existing in_progress AutomationCondition to capture both in progress runs and in progress backfills. It keeps these as separate conditions to maximize flexibility (and also increases explainability in the UI, as you can tell if an asset is part of a backfill but not an active run, or vice-versa).

How I Tested These Changes

Changelog

AutomationCondition.in_progress() now will be true if an asset partition is part of an in-progress backfill that has not yet executed it. The prior behavior, which only considered runs, is encapsulated in AutomationCondition.execution_in_progress().

Copy link
Contributor Author

OwenKephart commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 311c3b8 to 66311c6 Compare October 10, 2024 17:30
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 593e7b0 to 8a9f734 Compare October 10, 2024 17:30
@OwenKephart OwenKephart requested a review from schrockn October 10, 2024 17:41
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 66311c6 to 1f03a21 Compare October 10, 2024 19:40
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch 2 times, most recently from adde185 to df8311b Compare October 10, 2024 22:56
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 1f03a21 to 59c7c45 Compare October 11, 2024 00:30
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from df8311b to 83eb88d Compare October 11, 2024 00:30
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 59c7c45 to ee98440 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 83eb88d to d163030 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from ee98440 to 28ef6c8 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from d163030 to 55db5d0 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 28ef6c8 to 9d0fd47 Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 55db5d0 to e6aa284 Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 9d0fd47 to 963f91e Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from e6aa284 to 2726512 Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 963f91e to e3cc307 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 2726512 to 363b5d2 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from e3cc307 to dface2b Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 363b5d2 to 29d740e Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from dface2b to 1973124 Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 29d740e to dd22d6e Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 1973124 to 00cd59a Compare October 15, 2024 18:52
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from dd22d6e to 24e4be2 Compare October 15, 2024 18:53
Copy link
Contributor Author

OwenKephart commented Oct 15, 2024

Merge activity

  • Oct 15, 3:52 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 3:59 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 4:01 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 4:03 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 4:05 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 4:06 PM EDT: A user merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 00cd59a to e559825 Compare October 15, 2024 19:56
Base automatically changed from 10-10-_refactor_move_all_operands_into_a_single_file to master October 15, 2024 19:58
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch 3 times, most recently from 22fabd3 to 1c77260 Compare October 15, 2024 20:02
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 1c77260 to b4b92a8 Compare October 15, 2024 20:04
@OwenKephart OwenKephart merged commit 792f58b into master Oct 15, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 10-10-create_backfill_in_progress_automationcondition branch October 15, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants