-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create backfill_in_progress AutomationCondition #25190
Merged
OwenKephart
merged 1 commit into
master
from
10-10-create_backfill_in_progress_automationcondition
Oct 15, 2024
Merged
Create backfill_in_progress AutomationCondition #25190
OwenKephart
merged 1 commit into
master
from
10-10-create_backfill_in_progress_automationcondition
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 10, 2024 17:30
311c3b8
to
66311c6
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 10, 2024 17:30
593e7b0
to
8a9f734
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 10, 2024 19:40
66311c6
to
1f03a21
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
2 times, most recently
from
October 10, 2024 22:56
adde185
to
df8311b
Compare
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 00:30
1f03a21
to
59c7c45
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 11, 2024 00:30
df8311b
to
83eb88d
Compare
This was referenced Oct 11, 2024
schrockn
approved these changes
Oct 11, 2024
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 17:18
59c7c45
to
ee98440
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 11, 2024 17:18
83eb88d
to
d163030
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 19:46
ee98440
to
28ef6c8
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 11, 2024 19:46
d163030
to
55db5d0
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 22:25
28ef6c8
to
9d0fd47
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 11, 2024 22:25
55db5d0
to
e6aa284
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 14, 2024 16:51
9d0fd47
to
963f91e
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 14, 2024 16:51
e6aa284
to
2726512
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 14, 2024 17:03
963f91e
to
e3cc307
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 14, 2024 17:03
2726512
to
363b5d2
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 17:32
e3cc307
to
dface2b
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 15, 2024 17:32
363b5d2
to
29d740e
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 17:55
dface2b
to
1973124
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 15, 2024 17:55
29d740e
to
dd22d6e
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 18:52
1973124
to
00cd59a
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 15, 2024 18:53
dd22d6e
to
24e4be2
Compare
Merge activity
|
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 19:56
00cd59a
to
e559825
Compare
Base automatically changed from
10-10-_refactor_move_all_operands_into_a_single_file
to
master
October 15, 2024 19:58
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
3 times, most recently
from
October 15, 2024 20:02
22fabd3
to
1c77260
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
October 15, 2024 20:04
1c77260
to
b4b92a8
Compare
OwenKephart
deleted the
10-10-create_backfill_in_progress_automationcondition
branch
October 15, 2024 20:06
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title. This converts the existing
in_progress
AutomationCondition to capture both in progress runs and in progress backfills. It keeps these as separate conditions to maximize flexibility (and also increases explainability in the UI, as you can tell if an asset is part of a backfill but not an active run, or vice-versa).How I Tested These Changes
Changelog
AutomationCondition.in_progress()
now will be true if an asset partition is part of an in-progress backfill that has not yet executed it. The prior behavior, which only considered runs, is encapsulated inAutomationCondition.execution_in_progress()
.