Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store allow_backfills in the sensor metadata #25203

Merged

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

This allows it to be transferred across the serdes boundary, enabling it for non-user code automation conditions

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming question

@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 83eb88d to d163030 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 32eeb3d to 9be9003 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from d163030 to 55db5d0 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch 2 times, most recently from 66e90c3 to 08182f2 Compare October 11, 2024 20:01
@OwenKephart OwenKephart dismissed schrockn’s stale review October 11, 2024 20:02

Went with emit_backfills, which I agree is better. Did a little chatGPT searching for a better name and was not successful. Ideally, this will be a pretty niche option for people to turn off.

@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 55db5d0 to e6aa284 Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 08182f2 to 4d6ab5b Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from e6aa284 to 2726512 Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 4d6ab5b to 09c9bd8 Compare October 14, 2024 16:52
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 2726512 to 363b5d2 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 09c9bd8 to 206a6ff Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 363b5d2 to 29d740e Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 206a6ff to 9c81ee7 Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from 29d740e to dd22d6e Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 9c81ee7 to f641df4 Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch from dd22d6e to 24e4be2 Compare October 15, 2024 18:53
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from f641df4 to 307febf Compare October 15, 2024 18:53
Copy link
Contributor Author

OwenKephart commented Oct 15, 2024

Merge activity

  • Oct 15, 3:52 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 4:07 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 4:08 PM EDT: A user merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 10-10-create_backfill_in_progress_automationcondition branch 4 times, most recently from 1c77260 to b4b92a8 Compare October 15, 2024 20:04
Base automatically changed from 10-10-create_backfill_in_progress_automationcondition to master October 15, 2024 20:06
@OwenKephart OwenKephart force-pushed the 10-10-store_allow_backfills_in_the_sensor_metadata branch from 307febf to dd36b71 Compare October 15, 2024 20:06
@OwenKephart OwenKephart merged commit f49e08c into master Oct 15, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 10-10-store_allow_backfills_in_the_sensor_metadata branch October 15, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants