-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.9] Update deprecation warnings for automation_condition, auto_materialize_policy, and freshness_policy #25208
Merged
OwenKephart
merged 1 commit into
master
from
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 11, 2024 00:53
67737ff
to
dc44e0e
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 11, 2024 00:53
f1ca462
to
c9ca6a0
Compare
schrockn
reviewed
Oct 11, 2024
@deprecated_param( | ||
param="freshness_policy", | ||
breaking_version="1.10.0", | ||
additional_warn_text="use freshness checks instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to docs?
schrockn
approved these changes
Oct 11, 2024
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 11, 2024 17:19
dc44e0e
to
d270ccb
Compare
This was referenced Oct 11, 2024
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 11, 2024 17:19
c9ca6a0
to
c032cfe
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 11, 2024 19:46
d270ccb
to
c3df4f8
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 11, 2024 19:47
c032cfe
to
e6e858a
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 11, 2024 20:02
c3df4f8
to
c7d0f99
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 11, 2024 20:02
e6e858a
to
fce786a
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 11, 2024 20:49
c7d0f99
to
ff16f41
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 11, 2024 20:50
fce786a
to
acf186a
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 15, 2024 20:14
e33254c
to
753d8b9
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 15, 2024 20:15
6c6c840
to
614f325
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 15, 2024 21:09
753d8b9
to
9598b9c
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 15, 2024 21:09
614f325
to
6ab1c49
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 16, 2024 23:37
9598b9c
to
233346a
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 16, 2024 23:37
6ab1c49
to
9be0fea
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 16, 2024 23:46
233346a
to
46054e3
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 16, 2024 23:46
9be0fea
to
50df664
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 17, 2024 00:20
46054e3
to
53a65f6
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 17, 2024 00:20
50df664
to
1a19970
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 17, 2024 16:39
53a65f6
to
dc4f6b2
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 17, 2024 16:39
1a19970
to
97b07ee
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 21, 2024 23:05
dc4f6b2
to
21b1295
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 21, 2024 23:05
97b07ee
to
932b33c
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 22, 2024 16:49
21b1295
to
a518dcc
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 22, 2024 16:49
932b33c
to
6ffaadd
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 22, 2024 17:04
a518dcc
to
6e32e15
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 22, 2024 17:04
6ffaadd
to
065e792
Compare
OwenKephart
force-pushed
the
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
branch
from
October 22, 2024 18:02
6e32e15
to
67c0a6b
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 22, 2024 18:02
065e792
to
ae9482f
Compare
OwenKephart
changed the base branch from
10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors
to
graphite-base/25208
October 22, 2024 20:33
…rialize_policy, and freshness_policy
OwenKephart
force-pushed
the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
from
October 22, 2024 20:37
ae9482f
to
6057291
Compare
OwenKephart
deleted the
10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy
branch
October 22, 2024 20:39
Grzyblon
pushed a commit
to Grzyblon/dagster
that referenced
this pull request
Oct 26, 2024
…rialize_policy, and freshness_policy (dagster-io#25208) ## Summary & Motivation As title. We're bumping back one more release on these deprecations to give a full release worth of non-experimental AutomationConditions before forcing a migration. As a note, the FreshnessPolicy object was always marked as deprecated, so it was not possible to use the freshness_policy params without getting a deprecation warning. However, I added those warnings to be extra explicit. ## How I Tested These Changes ## Changelog NOCHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title. We're bumping back one more release on these deprecations to give a full release worth of non-experimental AutomationConditions before forcing a migration.
As a note, the FreshnessPolicy object was always marked as deprecated, so it was not possible to use the freshness_policy params without getting a deprecation warning. However, I added those warnings to be extra explicit.
How I Tested These Changes
Changelog
NOCHANGELOG