Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9] Update deprecation warnings for automation_condition, auto_materialize_policy, and freshness_policy #25208

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

As title. We're bumping back one more release on these deprecations to give a full release worth of non-experimental AutomationConditions before forcing a migration.

As a note, the FreshnessPolicy object was always marked as deprecated, so it was not possible to use the freshness_policy params without getting a deprecation warning. However, I added those warnings to be extra explicit.

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 67737ff to dc44e0e Compare October 11, 2024 00:53
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from f1ca462 to c9ca6a0 Compare October 11, 2024 00:53
@deprecated_param(
param="freshness_policy",
breaking_version="1.10.0",
additional_warn_text="use freshness checks instead.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to docs?

@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from dc44e0e to d270ccb Compare October 11, 2024 17:19
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from c9ca6a0 to c032cfe Compare October 11, 2024 17:19
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from d270ccb to c3df4f8 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from c032cfe to e6e858a Compare October 11, 2024 19:47
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from c3df4f8 to c7d0f99 Compare October 11, 2024 20:02
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from e6e858a to fce786a Compare October 11, 2024 20:02
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from c7d0f99 to ff16f41 Compare October 11, 2024 20:49
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from fce786a to acf186a Compare October 11, 2024 20:50
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from e33254c to 753d8b9 Compare October 15, 2024 20:14
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 6c6c840 to 614f325 Compare October 15, 2024 20:15
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 753d8b9 to 9598b9c Compare October 15, 2024 21:09
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 614f325 to 6ab1c49 Compare October 15, 2024 21:09
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 9598b9c to 233346a Compare October 16, 2024 23:37
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 6ab1c49 to 9be0fea Compare October 16, 2024 23:37
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 233346a to 46054e3 Compare October 16, 2024 23:46
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 9be0fea to 50df664 Compare October 16, 2024 23:46
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 46054e3 to 53a65f6 Compare October 17, 2024 00:20
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 50df664 to 1a19970 Compare October 17, 2024 00:20
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 53a65f6 to dc4f6b2 Compare October 17, 2024 16:39
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 1a19970 to 97b07ee Compare October 17, 2024 16:39
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from dc4f6b2 to 21b1295 Compare October 21, 2024 23:05
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 97b07ee to 932b33c Compare October 21, 2024 23:05
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 21b1295 to a518dcc Compare October 22, 2024 16:49
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 932b33c to 6ffaadd Compare October 22, 2024 16:49
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from a518dcc to 6e32e15 Compare October 22, 2024 17:04
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 6ffaadd to 065e792 Compare October 22, 2024 17:04
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors branch from 6e32e15 to 67c0a6b Compare October 22, 2024 18:02
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from 065e792 to ae9482f Compare October 22, 2024 18:02
Copy link
Contributor Author

OwenKephart commented Oct 22, 2024

Merge activity

  • Oct 22, 4:25 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 22, 4:38 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 22, 4:39 PM EDT: A user merged this pull request with Graphite.

@OwenKephart OwenKephart changed the base branch from 10-10-_1.9_remove_experimental_warnings_from_automationcondition_static_constructors to graphite-base/25208 October 22, 2024 20:33
@OwenKephart OwenKephart changed the base branch from graphite-base/25208 to master October 22, 2024 20:35
@OwenKephart OwenKephart force-pushed the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch from ae9482f to 6057291 Compare October 22, 2024 20:37
@OwenKephart OwenKephart merged commit de9a217 into master Oct 22, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 10-10-_1.9_update_deprecation_warnings_for_automation_condition_auto_materialize_policy_and_freshness_policy branch October 22, 2024 20:39
Grzyblon pushed a commit to Grzyblon/dagster that referenced this pull request Oct 26, 2024
…rialize_policy, and freshness_policy (dagster-io#25208)

## Summary & Motivation

As title. We're bumping back one more release on these deprecations to give a full release worth of non-experimental AutomationConditions before forcing a migration.

As a note, the FreshnessPolicy object was always marked as deprecated, so it was not possible to use the freshness_policy params without getting a deprecation warning. However, I added those warnings to be extra explicit.

## How I Tested These Changes

## Changelog

NOCHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants