Add test demonstrating that we do not hit the RESOURCE_EXHAUSTED error above a given threshold #25214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
7a838b5 to
10e5e25
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
1b7b02c to
c7a134b
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
10e5e25 to
2734223
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
c7a134b to
4ef46c9
Compare
This was referenced Oct 11, 2024
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
2734223 to
404dcbf
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
4ef46c9 to
4697f1f
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
404dcbf to
a3fc458
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
4697f1f to
eca04d1
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
a3fc458 to
6c2bb9c
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
eca04d1 to
6a077fb
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
6c2bb9c to
024f1c6
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
6a077fb to
4d1bc50
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
024f1c6 to
5411de6
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
cd41906 to
c02046f
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
4dfb21e to
bb14be6
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
c02046f to
12ccaf1
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
bb14be6 to
bef1ee2
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
12ccaf1 to
3bd0f6e
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
bef1ee2 to
a51c68c
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
3bd0f6e to
700d7e4
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
a51c68c to
3d4a568
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
700d7e4 to
b9a4a6e
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
3d4a568 to
9fa9d03
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
b9a4a6e to
8bf74fd
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
9fa9d03 to
23d5efa
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
8bf74fd to
12f4f07
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
23d5efa to
26443d6
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
12f4f07 to
cab309b
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
26443d6 to
f55765d
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
cab309b to
fad7f9a
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
f55765d to
f27155a
Compare
OwenKephart
force-pushed
the
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
branch
from
fad7f9a to
9a74d41
Compare
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
f27155a to
bf4c238
Compare
OwenKephart
changed the base branch from
10-10-propagate_automation_condition_information_through_the_ui_for_user_code_conditions
to
graphite-base/25214
…r above a given threshold
OwenKephart
force-pushed
the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
from
bf4c238 to
3fe0bb5
Compare
OwenKephart
deleted the
10-10-add_test_demonstrating_that_we_do_not_hit_the_resource_exhausted_error_above_a_given_threshold
branch
Grzyblon
pushed a commit
to Grzyblon/dagster
that referenced
this pull request
Oct 26, 2024
…r above a given threshold (dagster-io#25214) ## Summary & Motivation As title. This sets a baseline for feeling "safe" with this many assets. Some upgrades were needed to the test suite to make it more realistic such that we could trip the error. Future changes will allow us to greatly increase, or entirely remove, this limit. ## How I Tested These Changes Confirmed that if 1000 assets were supplied, we would fail this test. ## Changelog > Insert changelog entry or delete this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title. This sets a baseline for feeling "safe" with this many assets.
Some upgrades were needed to the test suite to make it more realistic such that we could trip the error.
Future changes will allow us to greatly increase, or entirely remove, this limit.
How I Tested These Changes
Confirmed that if 1000 assets were supplied, we would fail this test.
Changelog