[1.9] Promote hidden params to top-level args in AutomationConditionSensorDefinition #25206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
dd166d4 to
b376815
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
5351477 to
a6bf7c5
Compare
schrockn
reviewed
Oct 11, 2024
python_modules/dagster/dagster/_core/definitions/automation_condition_sensor_definition.py
Show resolved
Hide resolved
schrockn
approved these changes
Oct 11, 2024
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
b376815 to
bcfa13a
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
a6bf7c5 to
c727854
Compare
This was referenced Oct 11, 2024
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
bcfa13a to
77b6f21
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
c727854 to
f1103b3
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
77b6f21 to
b7da539
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
f1103b3 to
f1e8a25
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
b7da539 to
1c77116
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
f1e8a25 to
daaa074
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
1c77116 to
653b170
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
3e9969f to
c0492eb
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
4c439b1 to
0d8ea65
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
c0492eb to
f49ef30
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
0d8ea65 to
f5ee70a
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
f49ef30 to
bc611c5
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
f5ee70a to
f1f8963
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
bc611c5 to
87e68b4
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
f1f8963 to
74938cc
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
87e68b4 to
b3c916d
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
74938cc to
0f34286
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
b3c916d to
32fdc5f
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
0f34286 to
19e62ef
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
32fdc5f to
6ad20cb
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
19e62ef to
fcb2e05
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
6ad20cb to
3aee643
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
2 times, most recently
from
3cc3674 to
48a30da
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
3aee643 to
18f1399
Compare
OwenKephart
force-pushed
the
10-10-_1.9_update_default_value_of_allow_backfills_to_true
branch
from
48a30da to
49434bc
Compare
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
fce0b85 to
363624b
Compare
OwenKephart
changed the base branch from
10-10-_1.9_update_default_value_of_allow_backfills_to_true
to
graphite-base/25206
OwenKephart
force-pushed
the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
from
363624b to
696ee35
Compare
OwenKephart
deleted the
10-10-_1.9_promote_hidden_params_to_top-level_args_in_automationconditionsensordefinition
branch
Grzyblon
pushed a commit
to Grzyblon/dagster
that referenced
this pull request
Oct 26, 2024
…ensorDefinition (dagster-io#25206) ## Summary & Motivation As title -- these should be documented and visible to users. Open to suggestions on `use_user_code_server` as a name. ## How I Tested These Changes ## Changelog Added a new `use_user_code_server` paramter to `AutomationConditionSensorDefinition`. If set, the sensor will be evaluated in the user code server (as traditional sensors are), allowing custom `AutomationCondition` subclasses to be evaluated. To learn more, view the docs [TODO]. Added a new `default_condition` parameter to `AutomationConditionSensorDefinition`. If set, this condition will be used for any assets or asset checks within the selection that do not have an automation condition defined. Requires `use_user_code_server` to be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title -- these should be documented and visible to users.
Open to suggestions on
use_user_code_serveras a name.How I Tested These Changes
Changelog
Added a new
use_user_code_serverparamter toAutomationConditionSensorDefinition. If set, the sensor will be evaluated in the user code server (as traditional sensors are), allowing customAutomationConditionsubclasses to be evaluated. To learn more, view the docs [TODO].Added a new
default_conditionparameter toAutomationConditionSensorDefinition. If set, this condition will be used for any assets or asset checks within the selection that do not have an automation condition defined. Requiresuse_user_code_serverto be set.